709460 - GCLI needs a screenshot command

Status: RESOLVED FIXED

(DevTools :: Console, defect, P2)

Description

[Joe Walker [:jwalker]]

i.e.

  > screenshot foo.png
  Saved screenshot of current page to 'downloads/foo.png'

Comment 1

[Joe Walker [:jwalker]]

This needs to take into account bug 664693 comment 10 (and the few comments prior to that).

Comment 2

[barryvan]

Would it be possible to also add support for:

* screenshots copied directly to clipboard, rather than saved on disk;
* screenshots of the viewport/entire window; and
* screenshots of a particular area/element.

The last one could encapsulate the second (screenshot --elem body). I'm not sure of the syntax for it, though. Perhaps "screenshot --elem <selector>".

Comment 3

[Joe Walker [:jwalker]]

Bug triage, filter on PEGASUS.

Comment 4

[Joe Walker [:jwalker]]

Bug triage, filter on PEGASUS.

Comment 5

[Joe Walker [:jwalker]]

Attachment: upload 1

Basic implementation.
No tests, l10n incomplete, errors in getting default download directory.

Comment 6

[Joe Walker [:jwalker]]

https://tbpl.mozilla.org/?tree=Try&rev=b447debd6053

Comment 7

[Joe Walker [:jwalker]]

Attachment: upload 2

Basically working.
Just does current window, and only to a file right now. Enhancements welcome.

Comment 8

[Joe Walker [:jwalker]]

https://tbpl.mozilla.org/?tree=Try&rev=9dbf9f91493c

Comment 9

[Joe Walker [:jwalker]]

https://bugzilla.mozilla.org/show_bug.cgi?id=723431

Comment 10

[Victor Porof [:vporof][:vp]]

Can I take this?

Comment 11

[Joe Walker [:jwalker]]

(In reply to Victor Porof from comment #10)
> Can I take this?

You're welcome to

Comment 12

[Joe Walker [:jwalker]]

Just checked and that's the latest version.
It works OK, but can only screenshot the visible screen

Comment 13

[Victor Porof [:vporof][:vp]]

Cool, I'll play with it a bit.

Comment 14

[Joe Walker [:jwalker]]

GCLI Triage.

Comment 15

[Victor Porof [:vporof][:vp]]

Attachment: v3

Now able to screenshot the entire webpage view bounds or just a single node identified by a css selector.

Comment 16

[Joe Walker [:jwalker]]

Comment on attachment 626805 [details] [diff] [review]
v3

Review of attachment 626805 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!

::: browser/devtools/commandline/GcliCommands.jsm
@@ +195,5 @@
> +
> +    let source = ioService.newURI(data, "UTF8", null);
> +    persist.saveURI(source, null, null, null, null, file);
> +
> +    return "Saved to " + filename;

We're planning on adding a green tick-mark to indicate that the command executed correctly, and I'm expecting that the user will know the filename, so I think we can just return here.

In the future, I've been mulling over the idea that we should have an implicit --verbose flag for all commands which we could turn on/off globally or on a case by case basis.

Comment 17

[Victor Porof [:vporof][:vp]]

(In reply to Joe Walker from comment #16)
> Comment on attachment 626805 [details] [diff] [review]
> v3
> 
> Review of attachment 626805 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Thanks!
> 
> ::: browser/devtools/commandline/GcliCommands.jsm
> @@ +195,5 @@
> > +
> > +    let source = ioService.newURI(data, "UTF8", null);
> > +    persist.saveURI(source, null, null, null, null, file);
> > +
> > +    return "Saved to " + filename;
> 
> We're planning on adding a green tick-mark to indicate that the command
> executed correctly, and I'm expecting that the user will know the filename,
> so I think we can just return here.
> 

I'm not entirely sure that the user will know the filename right from the start. First time I tried a screenshot and didn't enter a fullpath, I almost got confused on whether the image will be saved in my downloads folder, or on my desktop (like os x does).

Maybe we should keep it?

Comment 18

[Joe Walker [:jwalker]]

(In reply to Victor Porof from comment #17)
> ...
> > We're planning on adding a green tick-mark to indicate that the command
> > executed correctly, and I'm expecting that the user will know the filename,
> > so I think we can just return here.
> > 
> 
> I'm not entirely sure that the user will know the filename right from the
> start. First time I tried a screenshot and didn't enter a fullpath, I almost
> got confused on whether the image will be saved in my downloads folder, or
> on my desktop (like os x does).
> 
> Maybe we should keep it?

Ok, you sold me.
Thanks.

Comment 19

[Joe Walker [:jwalker]]

https://tbpl.mozilla.org/?tree=Fx-Team&rev=a24414165cd4

Comment 20

[Rob Campbell [:rc] (:robcee)]

https://hg.mozilla.org/mozilla-central/rev/68600a8af079