71101 - patch needed to nsRenderingContextGTK.cpp for outliner

Status: VERIFIED FIXED

(Core :: Layout, defect)

Description

[(not reading, please use [e-mail] instead)]

this is a heads up (to the authors for nsRenderingContextGTK.cpp)

jan and I had to patch nsRenderingContextGTK.cpp for the outliner.

my patch was for a crasher, jan's was to add the dotted and dashed lines for
outliner.

I just checked it into the trunk, because hyatt has landed the outliner.

I'll attach a patch for an after-the-fact review.

Comment 1

[(not reading, please use [e-mail] instead)]

Attachment: patch I checked in, please review

Comment 2

[Axel Hecht]

Just adding, I crashed on solaris, built right after the initial
Makefile horkage.
Having poked seth about this, here is the output of the crasher when loading
the outliner.xul sample without this patch:

Document file:///tmp/mozilla/layout/xul/base/src/outliner/outliner.xul loaded
successfully
JavaScript error: 
chrome://global/content/outlinerBindings.xml#columnpicker.buildPopup() line 7:
currCol has no properties
 
Outliner is [object XULElement]
Arithmetic Exception

Comment 3

[(not reading, please use [e-mail] instead)]

there are some divide by zero bugs in the outliner.

(I think bienvenu has those patches).

for mailnews, I believe those divide by zero errors were exposed by hiding the
outliner.  (setting the hidden attribute to "true").

according to mscott, that caused the content to be destroyed.

I'm not sure what outliner.xul is doing, but that is something to keep in mind.

you should take this discussion to another bug.

Comment 4

[David Hyatt]

yup, sr=hyatt and closing this out.

Comment 5

[Chris Petersen]

Marking verified per last comments.