71358 - XUL-related changes from IBM bidi project

Status: VERIFIED FIXED

(Core :: XUL, defect)

Description

[Erik van der Poel]

This bug report will be used to attach the diffs for XUL-related files from the
IBM bidi project.

Comment 1

[Erik van der Poel]

Attachment: diffs for a XUL-related file from IBM bidi project

Comment 2

[Erik van der Poel]

Dave, please (have someone) review these changes. Thanks!

Comment 3

[David Hyatt]

IBM needs to patch the outliner code as well (which just recently landed).  It
draws and crops its own text.

Comment 4

[Frank Tang]

set to moz 0.9

Comment 5

[Erik van der Poel]

David, could we have an r or sr for the patch that is already in this bug
report, or do you want to see the outliner changes first?

Comment 6

[Frank Tang]

Do we need this to trun on IBMBID flag ? Can we land this later if hyatt do not 
have time to look at it soon?

Comment 7

[Frank Tang]

erik resign. reassign all his bug to ftang for now.

Comment 8

[Frank Tang]

hyatt- pleae review this as module owner.

Comment 9

[David Hyatt]

It looks like the bidi engine leaks.  nsIBidi is fetched without using a COM 
ptr.

Comment 10

[Frank Tang]

simon- 
I think we should use nsCOMPtr inside nsBidiPresUtils for mBidiEngine and 
mUnicodeUtils. Also, we should AddRef for GetBidiEngine. I am working on a fix 
for this

Comment 11

[Frank Tang]

here is a better patch
1. we make the nsBidiPresUtil using nsCOMPtr for service so we won't leak them
2. we use nsCOMPtr in the xul so we won't leak them. 
the nsBidiPresUtil itself is not an com object so we don't do that.

Comment 12

[Frank Tang]

Attachment: new patch

Comment 13

[Frank Tang]

change stuats to
wait for hyatt's review for new patch since 2001-05-10 15:54

Comment 14

[David Hyatt]

ok, sr=hyatt

Comment 15

[Frank Tang]

fixed and check in

Comment 16

[John Morrison]

rs verify checkin.