714178 - Expose CPP from configure to the build system

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

I don't think mozilla-central needs this, but the InstantBird folks do, and it's easy enough to do.

Comment 1

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Attachment: Patch

Comment 2

[Quentin Raynaud]

Yes we do need this. I just tried this patch on our win32 slave and here what we found out :
$(CPP) works well with gmake, it's an implicit variable replaced at use time by '$(CC) -E'.

When I call 'make showbuild' on a gmake objdir, I have this line : '/path/to/python.exe -O /path/to/mozilla/build/cl.py cl -E'
whie, using this patch, with pymake, I have the following value : 'cl -E -nologo'.

Using this value should work in our test case, but I'm not sure the result is what is expected. I believe we should find a patch on pymake. I tried to add 'CPP': '$(CC) -E', in pymake/implicit.py but it seems that '$(CC)' is resolved at init time rather that at use time (CPP = ' -E' when doing a showbuild).

Hope this helps a little...

Comment 3

[(not currently active) Ted Mielczarek]

Comment on attachment 584852 [details] [diff] [review]
Patch

Review of attachment 584852 [details] [diff] [review]:
-----------------------------------------------------------------

The inconsistent spacing in this file drives me nuts, but it's not worth worrying about.

Comment 4

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

http://hg.mozilla.org/projects/build-system/rev/c56d11e05feb

Comment 5

[Florian Quèze [:florian]]

Is using 'cl -E -nologo' instead of '/path/to/python.exe -O /path/to/mozilla/build/cl.py cl -E' (as mentioned in comment 2) something that should worry us?

Comment 6

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Probably not.  cl.py is only used for dependency generation for future rebuilds.

Comment 7

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

https://hg.mozilla.org/mozilla-central/rev/c56d11e05feb