71485 - Convert bindingattached/detached to <constructor>/<destructor>

Status: RESOLVED FIXED

(Core :: XUL, defect)

Description

[David Hyatt]

Switch 'em over.

Comment 1

[David Hyatt]

Attaching patches.  These include the patch to 71262.

Comment 2

[David Hyatt]

Attachment: content DLL patch

Comment 3

[David Hyatt]

Attachment: patch t o xbl files

Comment 4

[Peter "jag" Annema]

Nits:

Indentation:

Index: global/resources/content/colorpickerBindings.xml
+         <constructor><![CDATA[
+        this.initialize();
+      ]]></constructor>

Index: global/resources/content/menulistBindings.xml
     <implementation>
+         <constructor>
+           this.setInitialSelection()
+         </constructor>

Index: global/resources/content/tabBindings.xml
<constructor/> uses tabs instead of spaces.

Index: global/resources/content/toolbarBindings.xml
+         <constructor>
         this.init(event);
-      </handler>
-    </handlers>
+      </constructor>
+    </implementation>

Index: global/resources/content/xulBindings.xml
+      <constructor action="var str = this.boxObject.getProperty('value'); 
+                                                if (str) {
+                                                  this.inputField.value=str;
+                                                 
this.boxObject.removeProperty('value');
+                                                }"/>

r=jag on both patches with a request to fix the indentation.

Comment 5

[Joe Hewitt (gone)]

sr=hewitt on the xml part

Comment 6

[David Hyatt]

Fixed.