71537 - fdlibm.lib failing to build when JS Engine is built?

Status: VERIFIED FIXED

(Core :: JavaScript Engine, defect)

Description

[Phil Schwartau]

Reported by [e-mail]: 

OK. This is the second time I'm deleting my old tree and starting fresh so
it can't be my tree.

When I'm attempting to build my tree, it fails when it tries to create
js3250.dll. The problem is:

+++ make: Creating DLL: .\WIN32_O.OBJ\js3250.dll
LINK : fatal error LNK1181: cannot open input file
"fdlibm\WIN32_O.OBJ\fdlibm.lib"



Response from mkaply: 

Did this just start today? Are you by chance building on Win95?
This line:

http://lxr.mozilla.org/seamonkey/source/js/src/makefile.win#185

$(FDLIBM_LIBRARY):
!if "$(WINOS)" == "WIN95"
!if defined(VERBOSE)
    @echo +++ make: cannot recursively make on win95 using command.com, use
w95make.
!endif
!else
    @echo +++ make: %MAKE_ARGS% in $(MAKEDIR)\$@
        @cd fdlibm
        @$(NMAKE) -f makefile.win %%MAKE_ARGS%%
     @cd $(MAKEDIR)
!endif

Should be invoking the make in fdlibm if it doesn't exist.




Assigning to mkaply, since this may be related to recent changes
for bug 59855. cc'ing mccabe -

Comment 1

[Mike Kaply [:mkaply]]

Fix checked in - WIN95 only build problem.

Comment 2

[Håkan Waara]

Yep. Mkaply fixed this yesterday, and now it works. Verifying.