71648 - Dump of stylesheets in Viewer outputs erroneous selectors

Status: RESOLVED FIXED

(Core Graveyard :: Viewer App, defect, P3)

Description

[Daniel Glazman (:glazou) (not active in Mozilla any more)]

|nsCSSStyleRuleImpl::List| should use |nsCSSSelector::ToString|. For the
moment, the selectors' output from the viewer is false in various ways.
Tis is a very easy fix.

Comment 1

[Daniel Glazman (:glazou) (not active in Mozilla any more)]

accepting bug

Comment 2

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

*** Bug 71649 has been marked as a duplicate of this bug. ***

Comment 3

[rubydoo123]

setting to moz0.9

Comment 4

[Daniel Glazman (:glazou) (not active in Mozilla any more)]

Attachment: patch for # 71648

Comment 5

[Daniel Glazman (:glazou) (not active in Mozilla any more)]

Proposed fix for this bug. Just reuses |nsCSSSelector::ToString| instead
of re-doing all the work...

r= and sr= needed

Comment 6

[Marc Attinasi]

Ah, the beauty of factoring! sr=attinasi (but make sure Pierre has reviewed to
too please.)

Comment 7

[Pierre Saslawsky]

Two remarks:

- The line you add should be
     mSelector.ToString(buffer, mSheet, PR_FALSE, 0);
  instead of
     mSelector.ToString(buffer, mSheet, PR_FALSE);

- You should replace the line that immediately follows the one you add:
     buffer.AppendWithConversion("weight: ");
  with
     buffer.AppendWithConversion(" weight: ");

With these two changes, r=pierre

Comment 8

[Daniel Glazman (:glazou) (not active in Mozilla any more)]

I agree 100% with the comments :

  * missing arguments is caused by the integration of 71647...

  * I already added the missing whitespace to my own build to get a better
    and more readable output

checking in asap

Comment 9

[Daniel Glazman (:glazou) (not active in Mozilla any more)]

checked in ;-)