72010 - mutation event listeners on document don't work

Status: VERIFIED FIXED

(Core :: DOM: Events, defect, P2)

Description

[Alex Fritze]

document.addEventListener( <<any mutation event>>, ... )
doesn't work in xul, html and xml.

Comment 1

[Alex Fritze]

Attachment: patch for xml/html docs

Comment 2

[Alex Fritze]

Attachment: patch for xul docs

Comment 3

[Blake Ross]

This is hyatt's baby.

Comment 4

[joki (gone)]

I agree, to the extent that I'm going to assign it to him.

Hyatt, if you want a review gimme a call but I'll let you make the call on any 
patch affecting mutation events since you'd know how to test this better than I.

So what is the bug, exactly.  The mutation listener bit isn't getting set in the 
case of listeners on the doc?

Comment 5

[Alex Fritze]

That's right. The bit isn't being set, because the listener manager of the doc 
can't get a pointer to the window in nsEventListenerManager::AddEventListener(.)

That is because the document fails to set itself as mTarget on its listener 
manager when it creates it.

Comment 6

[David Hyatt]

Yeah, all content nodes do that, but the doc isn't.  Should be trivial to fix.

Comment 7

[David Hyatt]

Targeting...

Comment 8

[David Hyatt]

Reassigning to dr.

sr=hyatt on the patch.

Comment 9

[Dan Rosen]

accepting. hyatt: did you just want me to r= and check in?

Comment 10

[David Hyatt]

Yeah, it's good to go.

Comment 11

[Dan Rosen]

fix checked in.

Comment 12

[Vladimir Ermakov]

Verifying on build 2001-04-10-04-trunk Windows 98