72112 - nsIPrompt impls need to coallesce into a single impl

Status: VERIFIED FIXED

(Core Graveyard :: Embedding: APIs, defect)

Description

[Judson Valeski]

In order for nsIPrompt dialog implementatin overriding to work, we need all the
nsIPrompt usages to funnel up to a single implementation. we talked about having
a single nsIPrompt service that was front-ended by a nsIPromptInternal
implementation that resides above necko which shields necko nsIPrompt calls from
having to know about nsIDOMWindow. Other current nsIPrompt impls/usages would
just use the root nsIPrompt dialog service directly (unless they too needed some
nsIDOMWindow shielding wrapper).

Comment 1

[Peter "jag" Annema]

Nice... no patches...

So anyway:
http://lxr.mozilla.org/seamonkey/source/mailnews/base/prefs/resources/content/AccountWizard.js#175

Uppercase C on Confirm instead of lowercase. Patch coming up.

Comment 2

[Peter "jag" Annema]

Attachment: [patch] Fix case.

Comment 3

[Dan M]

Been waiting for someone to knock me around for that. Thanks Jag! (I broke that 
file and 20 others. Fixes for all have been checked in.)

Comment 4

[Michael Dunn]

Correction: Changing QA contact for the Embed API bugs to David Epstein.

Comment 5

[Dan M]

nsIPrompt is now universally implemented by nsIPromptService. (Or rather, Viewer 
and some of the testbeds still claim to implement nsIPrompt, but they'll never be 
asked for their implementation, since that code path has been unhooked; diverted 
to the new service.) Viewer is not slated for updating, since it has never cared 
about such things and it would be astoundingly tedious to make it care. Work 
remaining on the testbed apps is accounted for in bug 75745.

Comment 6

[David Epstein]

changed QA contact to dsirnapalli. He's looking at this interface.

Comment 7

[dsirnapalli]

-- verified.