72366 - "Get All New Messages" shouldn't be disabled

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Message Display, defect, P2)

Description

[R.K.Aa.]

linux CVS 2001-0317
The "Get all new messages" dropdown menu on Get Msg button arrow is permanently
disabled, and doesn't work.

Comment 1

[Håkan Waara]

How many accounts do you have set up?

Comment 2

[R.K.Aa.]

Two POP accounts, the usual Local Folder, and a news-server. (POP doesn't hang
for me btw.) The menu is permanently disabled. It doesn't matter what account or
folder i have selected.

Comment 3

[R.K.Aa.]

err.. that was "POP3" accounts.

Comment 4

[Håkan Waara]

do you build yourself or download from mozilla.org?

if the latter is true, then please try a fresh profile. if former, do a clean
clobber build and see what happens.

Comment 5

[R.K.Aa.]

it's a CVS build, but made from source.tar.gz from the 16th and then updated via
CVS. If noone else sees this it's a local error after all i guess. Resolving as
invalid.

Comment 6

[R.K.Aa.]

getting it outta the way.

Comment 7

[Håkan Waara]

I see this right now, no need to verify it invalid already.

(why did you conclude it was a local error because I asked questions?)

Reopening

Comment 8

[Håkan Waara]

cc racham since he was the one who hacked this menubutton up IIRC.

Comment 9

[Håkan Waara]

this is happening me quite often now. upping severity to major since it blocks 
my use of that function often.

Comment 10

[(not reading, please use [e-mail] instead)]

re-assign to racham

Comment 11

[xolaware.llc]

i am now having this problem on mac nightly builds (currently using 2001032308,
2 POP accounts).

sometimes using the "Get all new messages" menu item of the "Get new messages
for" submenu will cause the item to become enabled, but it still does not work
properly (i.e. choosing "Get All New Messages" only looks in the last open POP
account; immediately selecting the second POP account and doing get new messages
for that account retrieves the messages.)

i don't think i was having this problem on mac a few days ago.

Comment 12

[Peter Lairo]

WFM - mozilla 0.8.1 (winNT, imap server) from menu and icon dropdown

Comment 13

[racham]

This is a post-merge problem...So, one should be fine on 0.8.1 builds.

Also, on 0.9 builds I noticed that it is not permanently disabled. If you go the
File menu and Select 'Get New Messages for" and then Select 'Get All New
Messages' and then come back click on the drop-marker of the GetMsg button, you
will find the 'Get All New Messages' option here enabled now. I will investigate
more on this regression.

Comment 14

[scottputterman]

I have what I think is the fix for this.  Basically, we only updated the 
command when the file menu was opened.  Instead, we need to update the command 
when either the file menu is opened or when the toolbar menu is opened.  I 
created a commandset for the get menu and use it when both the file menu and 
get msg toolbar menu are opened.

Comment 15

[scottputterman]

Attachment: patch

Comment 16

[racham]

reviewed & tested.

r=bhuvan.

Seth, please do sr=.

Comment 17

[racham]

Seth's sr taken from the similar fix in bug 73118.

Fixed.

Comment 18

[esther]

Using build 2001-05-07 on win and mac and 2001-05-08 on linux the drop down menu 
item "Get all New Messages" is always enabled now.  Verified.