72542 - Java Software installation dialog appears too wide

Status: VERIFIED FIXED

(Core Graveyard :: Installer: XPInstall Engine, defect, P1)

Description

[shrirang khanzode]

Pls reassign to correct component if incorrect. Thx

Steps
Install trunk build 0319 without java
go to java.sun.com
click on 'getht eplugin' icon on top right
select 'Windows java plugin'
Observe that the dialog titled' Items to Install' appears too wide and almost 
ttakes up the whole screen width.

Comment 1

[Henrik Gemal]

not installer but xpi installer...

Comment 2

[dbragg]

Nominating for nsbeta1.  (Regression from themes changes)

Comment 3

[dbragg]

Oh yeah, forgot to add that this isn't just the Java download, it's our confirm
dialog in general.

Comment 4

[Daniel Veditz [:dveditz]]

This is a regression due to the skin changes, right? Doesn't look like anyone 
else touched our dialog recently.

Comment 5

[Daniel Veditz [:dveditz]]

Looks like fallout from hewitt's recent (3/15) skinnability changes, 
reassigning

Comment 6

[Joe Hewitt (gone)]

This is classic theme only.  I changed the xul and updated modern appropriately
but I forgot to update classic.  See patch:

Comment 7

[Joe Hewitt (gone)]

Attachment: patch to fix

Comment 8

[Daniel Veditz [:dveditz]]

r=dveditz, though I'd like dbragg to take a look and verify that 40em is wide 
enough.

Comment 9

[dbragg]

40em looks good.  That's what I had in there before.
r=dbragg

Comment 10

[Ben Goodger (use ben at mozilla dot org for email)]

sr=[e-mail]

Comment 11

[Joe Hewitt (gone)]

fixed

Comment 12

[Jimmy Lee]

Build: 2001-04-11-08-trunk(LINUX)

Looks good now.  Marking Verified!