72603 - Form manager captures bad values for sample2 page

Status: VERIFIED FIXED

(Toolkit :: Form Manager, defect)

Description

[Stephen P. Morse]

From menu select tasks->privacy->form-manager->demo
Click on sample 2
Enter a value in any text field (e.g., First Name)
From menu select edit->save-form-data
From menu select edit->prefill-form

At this point you will get a preview dialog showing the values that are going to 
get prefilled.  The FirstName value is there and is correct.  But there are also 
values for Card.Type, Card.Exp.Month, and Card.Exp.Year and these values are all 
bogus (consist of line-feeds and spaces and nothing else).

Comment 1

[Stephen P. Morse]

Problem here is in the following html:

    <select name="Card.Type">
      <option value="">
      </option>
      <option value="V">
        Visa
      </option>
      <option value="MC">
        MasterCard
      </option>
    </select>

Assume that the last option (master card) is selected.  Form manager will 
capture both the option value ("MC") and the option text ("MasterCard") so as to 
maximize the likelyhood of finding an appropriate value in a select list on some 
other page that it is asked to prefill.

Unfortunately the option text is written across several lines.  When form 
manager does a call to GetText, it gets all the text between the <option> and 
</option> tags, including the linefeeds and leading spaces.  And if the first 
option (blank) is selected in the example above, the linefeeds and spaces are 
all it gets.  So we need to trim away leading and trailing linefeeds and spaces 
before capturing the text.

Attaching a patch that does just that.

Comment 2

[Stephen P. Morse]

Attachment: patch to trim linefeeds and spaces from text of option

Comment 3

[Stephen P. Morse]

Attachment: Updating patch to stip out \t and \r as well (per reviewer's comment).

Comment 4

[Peter "jag" Annema]

r=jag

Comment 5

[Stephen P. Morse]

cc'ing alecf for super review

Comment 6

[Stephen P. Morse]

cc'ing alecf for super review

Comment 7

[Alec Flett]

easy enough. sr=alecf

Comment 8

[Stephen P. Morse]

Fix checked in.

Comment 9

[Terri Preston]

Verified fix checked into lxr.mozilla.org