72774 - Not handling SYST failure correctly

Status: VERIFIED FIXED

(Core Graveyard :: Networking: FTP, defect)

Description

[Bill Nottingham]

Could very well be related to bug 72026; however, this is with a *valid* link.

Build ID: 2001032011, on Linux, Red Hat 7-ish.

Enter

ftp://space.mit.edu/pub/davis/

in the location bar, and hit enter; it makes the FTP connection and then
segfaults.

Backtrace is (sorry, no debugging symbols yet):

(gdb) bt
#0  0x41290294 in NSGetModule () from /usr/lib/mozilla/components/libnecko2.so
#1  0x408e4cb9 in NSGetModule () from /usr/lib/mozilla/components/libnecko.so
#2  0x408e4c2f in NSGetModule () from /usr/lib/mozilla/components/libnecko.so
#3  0x400c07f3 in PL_HandleEvent () at eval.c:41
#4  0x400c0701 in PL_ProcessPendingEvents () at eval.c:41
#5  0x400c179f in nsEventQueueImpl::ProcessPendingEvents () at eval.c:41
#6  0x4051a172 in nsJSUtils::mCachedSecurityManager ()
   from /usr/lib/mozilla/components/libwidget_gtk.so
#7  0x40519ec1 in nsJSUtils::mCachedSecurityManager ()
   from /usr/lib/mozilla/components/libwidget_gtk.so
#8  0x4042001e in g_io_unix_dispatch () from /usr/lib/libglib-1.2.so.0
#9  0x404217f3 in g_main_dispatch () from /usr/lib/libglib-1.2.so.0
#10 0x40421dd9 in g_main_iterate () from /usr/lib/libglib-1.2.so.0
#11 0x40421f8c in g_main_run () from /usr/lib/libglib-1.2.so.0
#12 0x405df803 in gtk_main () from /usr/lib/libgtk-1.2.so.0
#13 0x4051a6a2 in nsJSUtils::mCachedSecurityManager ()
   from /usr/lib/mozilla/components/libwidget_gtk.so
#14 0x403cac5e in object.2 () from /usr/lib/mozilla/components/libnsappshell.so
#15 0x0804d7eb in JS_PushArguments () at eval.c:41
#16 0x0804e0bb in JS_PushArguments () at eval.c:41
#17 0x4025c207 in __libc_start_main () from /lib/libc.so.6

Comment 1

[Bradley Baetz]

Confirming.

###!!! ASSERTION: You can't dereference a NULL nsCOMPtr with operator->().:
'mRawPtr != 0', file ../../../../dist/include/nsCOMPtr.h, line 648
###!!! Break: at file ../../../../dist/include/nsCOMPtr.h, line 648

(gdb) bt
#0  0x41c665d9 in DataRequestForwarder::OnStartRequest (this=0x8695c60, 
    request=0x8811fb8, ctxt=0x0) at ../../../../dist/include/nsCOMPtr.h:648
#1  0x40ad3f98 in nsOnStartRequestEvent::HandleEvent (this=0x41d007c8)
    at ../../../dist/include/nsCOMPtr.h:647
...

mListener is 0x0, according to gdb.

Comment 2

[Doug Turner (:dougt)]

Marking as a smoketest blocker until we understand why this regressed.

Comment 3

[Doug Turner (:dougt)]

Does not crash anymore.

However the bug is that this server does not understand the SYST command, and we
don't properly handle this case. The server response is:


"500 'SYST': command not understood.  "

In response to this, a bit later, we issue the NLST command instead of the LIST
command.

Comment 4

[Doug Turner (:dougt)]

Attachment: Fixes bug.

Comment 5

[Doug Turner (:dougt)]

Last patch:
- fixes handling error when after a SYST command.
- clears mResponseMsg which is displayed to the user if an error occurs when 
building a stream converter.

bbaetz, can you review?
darin, can you sr?

Comment 6

[Bradley Baetz]

r=bbaetz

Comment 7

[Doug Turner (:dougt)]

fix is in.

Comment 8

[benc]

VERIFIED:
Mozilla 0.9 all plats
I didn't do a trace, but I tested everything anyhow.

+maketest
NOTE: testing this via proxy is not needed, b/c this activity is delegated to
the proxy server.