73194 - switching to new profile breaks disk cache

Status: VERIFIED FIXED

(Core :: Networking: Cache, defect)

Description

[Conrad Carlen (not reading bugmail)]

In nsDiskCacheObserver::Observe, when it responds to a profile change, it does
not ensure the the cache dir that it sets up exists. If you switch to a profile
from which the new cache has never been run, this causes horrible things to
happen. During initialization, it ensures that the cache dir exists, but on a
profile change, this check is never performed. It needs to be.
The patch calls ensureCacheDirectory() in two more places. Shouldn't
ensureCacheDirectory just be called from nsDiskCacheDevice::setCacheDirectory so
this could be done all in one place?
Another thing about nsDiskCacheObserver - it does not implement
nsSupportsWeakReference so, in registering with observer service, observer
service will hold a strong ref to it. Not sure if that's bad in this case but
have a look.

Comment 1

[Conrad Carlen (not reading bugmail)]

Attachment: patch to ensure dir exists

Comment 2

[gordon]

How do we switch profiles?  When does it occur?

Comment 3

[Conrad Carlen (not reading bugmail)]

We support it for embedding - Seamonkey does not do it yet. The embedding
samples mfcEmbed (Win) and PPEmbed (Mac) both do it. They are part of the
standard build. 

Comment 4

[Judson Valeski]

Profile switching occurs whenever a profile switching enabled application
indicates (via UI similar to the profile manager) that the user is changing. in
mfcEmbed this is done by bringing up the switch profile dialog and selecting a
different user/profile and clicking ok.

For a description of "how" to test profile switching, see the "Profile
Switching" section in here
http://www.mozilla.org/quality/smoketests/embed-basic-test.html.

Comment 5

[Judson Valeski]

r=valeski

Comment 6

[Patrick C. Beard]

Patch looks fine to me. Will check in on branch, and it should get checked in on 
tip later today. You all might want to work with DISKCACHE1_BRANCH to get the 
latest and greatest. Just pull mozilla/netwerk/cache/public and src with this 
tag. r=beard

Comment 7

[Patrick C. Beard]

Fix checked in to trunk.

Comment 8

[Tracy Walker [:tracy]]

verified on 0402 mfcembed