73234 - nsInputStreamChannel needs to forward itself as the request in progress events

Status: RESOLVED FIXED

(Core :: Networking, defect)

Description

[Darin Fisher]

nsInputStreamChannel needs to forward itself as the request in progress events
(eg. nsHTTPChannel implements nsIProgressEventSink on behalf of the socket
transport).

Comment 1

[Darin Fisher]

Attachment: fixes the problem

Comment 2

[Darin Fisher]

dougt, rpotts: can you review this patch?  thx!

Comment 3

[Doug Turner (:dougt)]

it looks fine. sr=dougt.

Comment 4

[rpotts (gone)]

looks good... r=rpotts

-- rick

Comment 5

[Darin Fisher]

fix checked in.

Comment 6

[rpotts (gone)]

Guess what...  the patch was wrong :-(

i'm reopening this one, so I cna make sure that it gets fixed...

Comment 7

[rpotts (gone)]

-> rpotts...  I want to make sure that this gets in for 0.9.1

Comment 8

[Doug Turner (:dougt)]

why is it wrong? / what did it break?

Comment 9

[rpotts (gone)]

Attachment: patch for the patch :-)

Comment 10

[rpotts (gone)]

I've just attached a new patch to the old patch which correctly passes the
nsInputStreamChannel out as the request - rather than the underlying transport
request...

When the transport request was passed out, the progress info would be ignored by
the DocLoader because it did not recognize the request - ie. an OnStartRequest()
for the request had not been fired (only the OnProgress...)

Comment 11

[Darin Fisher]

r/sr=darin

Comment 12

[rpotts (gone)]

I'll check this in asw soon as I get an a= and the tree opens :-)

Comment 13

[Judson Valeski]

r=valeski

Comment 14

[rpotts (gone)]

blah...

Comment 15

[Asa Dotzler [:asa]]

a= [e-mail] for checkin to 0.9.1 (on behalf of drivers).

Comment 16

[rpotts (gone)]

fix checked in...