Closed
Bug 73355
Opened 23 years ago
Closed 23 years ago
Clean up (get rid of?) prefutilities.js
Categories
(SeaMonkey :: Preferences, defect)
SeaMonkey
Preferences
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: jag+mozbugs, Assigned: maolson)
References
Details
Attachments
(2 files)
23.06 KB,
patch
|
Details | Diff | Splinter Review | |
1.91 KB,
patch
|
Details | Diff | Splinter Review |
prefutilities.js has a lot of code that could (and should) move into the only xul file that uses it (set homepage function to pref-navigator.xul/js, history stuff to pref-history.xul).
Assignee | ||
Comment 1•23 years ago
|
||
Assignee | ||
Comment 2•23 years ago
|
||
Alec, Ben; Would like your opinion(s) if you have one on whether or not prefutilities.js should be split up and cvs removed. Most of the functions defined there are only used in one place, so we don't seem to be getting much code sharing benefit here.
Status: NEW → ASSIGNED
Assignee | ||
Comment 3•23 years ago
|
||
For whatever reason, our lovely new bugzilla system excluded alecf and ben in that last update. Trying again. - Could you guys jot your opinions down please?
Assignee | ||
Comment 4•23 years ago
|
||
The prefutilities stuff looks good jag. Now do we want another bug for nsJSComponentManager.js, since it looks like a pretty thin wrapper? - If someone wants to wrap their getService or createInstance in a try {}, should we force them do it at the callsite?
Assignee | ||
Comment 5•23 years ago
|
||
r=mao
Assignee | ||
Comment 6•23 years ago
|
||
r=timeless (we really should get those chrome makefiles killed).
Comment 8•23 years ago
|
||
sr=ben
Reporter | ||
Comment 9•23 years ago
|
||
+ var urlBarHistory = Components.classes["@mozilla.org/browser/urlbarhistory;1"] + .getService(Components.interfaces.nsIUrlbarHistory); + urlBarHist.clearHistory(); Spot the bug... Fixed locally :-) | function prefCacheSelectFolder() It looks like that function isn't used any longer. I'll just check this in anyway in case someone wants to turn that back on again.
Reporter | ||
Comment 10•23 years ago
|
||
Checked in, marking fixed.
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
Reporter | ||
Comment 11•23 years ago
|
||
extensions/p3p is referencing prefutilities.js and strres.js. This is unreviewed code (and not part of the build) which was checked in to make review easier (or so I've been told), therefore I haven't bothered fixing it nor waiting for another round of r=/sr=, but treated it as if wasn't checked in yet. I've mailed the author he could safely remove the prefutilities.js and strres.js inclusions from his code.
Comment 12•23 years ago
|
||
vrfy fixed: checked my linux debug and verif/pkg'd builds and prefutlities.js is no longer around. also checked lxr, and now that file is only mentioned in pref-P3P.xul and pref-P3Pcust.xul. [but as jag said, he's already pinged the owner of those.]
Status: RESOLVED → VERIFIED
Updated•20 years ago
|
Product: Browser → Seamonkey
You need to log in
before you can comment on or make changes to this bug.
Description
•