Closed Bug 73404 Opened 24 years ago Closed 21 years ago

Moving a subfolder doesn't delete *.sbd directory.

Categories

(SeaMonkey :: MailNews: Message Display, defect)

Product:
SeaMonkey
Component:
MailNews: Message Display
Platform:
x86
Windows 2000
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: kazhik, Assigned: Bienvenu)

References

Details

Attachments

(1 file, 3 obsolete files)

patch v4
1.10 KB, patch
Details | Diff | Splinter Review
Moving a subfolder doesn't delete *.sbd directory. Steps to reproduce: (1) Create a subfolder. (2) Move it to another place by drag and drop. The arrow which indicates subfolder remains. *.sbd direcotry isn't deleted.
over to naving.
Assignee: sspitzer → naving
Yes the .sbd directory will be there, but it will be empty.
Attached patch patch (obsolete) — — Splinter Review
.sbd is deleted with this patch. But the icon for the subfolder remains.
Attached patch patch, v2 (obsolete) — — Splinter Review
The previous patch doesn't check whether there are other subfolders or not.
Attachment #75382 - Attachment is obsolete: true
Blocks: 123209
Does this patch work yet? Can it be checked in?
Comment on attachment 75385 [details] [diff] [review] patch, v2 This patch still works.
Attachment #75385 - Flags: review?(naving)
Navin, how can we request a review to possibly get this patch checked in?
Blocks: 46365
Attached patch patch v3 (obsolete) — — Splinter Review
patch v2 deletes *.sbd even if it contains subfolders.
Attachment #75385 - Attachment is obsolete: true
Attachment #119790 - Flags: review?(bienvenu)
Is it possible to get this in for 1.4 beta?
CC-ing bienvenu, he might be interested.
Comment on attachment 119790 [details] [diff] [review] patch v3 you should add a comment that i.Exists() checks to see if the .sbd directory is empty or not (that's what it does, right?) Also, you don't need the extra braces around the call to parentPath.Delete. You've made sure that this works in the case of a non-empty parent directory, right? It looks fine, otherwise, thx for working on this.
mass re-assign.
Assignee: naving → sspitzer
Attached patch patch v4 — — Splinter Review
Added a comment and deleted the braces.
Attachment #119790 - Attachment is obsolete: true
Attachment #122981 - Flags: review?(bienvenu)
Comment on attachment 75385 [details] [diff] [review] patch, v2 clearing obsolete review request
Attachment #75385 - Flags: review?(naving)
Attachment #119790 - Flags: review?(bienvenu)
There is a patch, why has this bug stalled?
taking - I'll try this out.
Assignee: sspitzer → bienvenu
fix checked in, r/sr=me, thanks Kazuhiko
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
Attachment #122981 - Flags: review?(bienvenu)
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: