73775 - Editor toolbar should use toolbarseparator not spring

Status: VERIFIED FIXED

(Core :: DOM: Editor, defect)

Description

[[e-mail]]

Index: editor.xul
===================================================================
RCS file: /cvsroot/mozilla/editor/ui/composer/content/editor.xul,v
retrieving revision 1.89
diff -u -r1.89 editor.xul
--- editor.xul  2001/03/22 00:57:09     1.89
+++ editor.xul  2001/03/28 13:58:49
@@ -156,7 +156,7 @@
     <button id="previewButton"/>
     <menubutton id="printButton" />
     <button id="spellingButton"/>
-    <spring style="width: 8px"/>
+    <toolbarseparator/>
     <button id="imageButton"/>
     <button id="hlineButton"/>
     <button id="tableButton"/>

Comment 1

[Kathleen :Brade]

reassign to charley

Comment 2

[Håkan Waara]

r=hwaara, if this is the only place in those files where this happens.

Comment 3

[[e-mail]]

Attachment: added class for Modern skin support

Comment 4

[Charles Manske]

There's no support for "toolbarseparator-primary" in classic theme, so there's
no visible separator. If we use just <toolbarseparator/>, there's no visible
separator in either theme.
Hewitt: are these bugs?

Comment 5

[rubydoo123]

moving to mozilla0.9.1

Comment 6

[Charles Manske]

Neil? Hewitt? Are we comfortable with this change without support in classic?

Comment 7

[[e-mail]]

Attachment: revised patch streches toolbar separators for Classic

Comment 8

[Charles Manske]

Latest patch works fine.

Comment 9

[Charles Manske]

sr=sfraser
checked in.

Comment 10

[Kathleen :Brade]

verified using optimized linux build from today 8am.