73801 - Need to disable the Delete button & menu item Delete Address Book when PAB or CAB is selected

Status: RESOLVED FIXED

(SeaMonkey :: MailNews: Address Book & Contacts, defect)

Description

[jglick]

In the AB, select either the Personal Address Book or Collected AB.  Click 
"Delete".  The error dialog appears:

Text: "You are not allowed to delete the Personal and Collected Addresses 
address books.  Please deselect them for your delete operation".

Title: "Personal and Collected address books cannot be deleted"

Dialog Title needs correct capitalization and is a little wordy(Capitalize all 
words, except articles, conjunctions and prepositions. Articles, conjunctions 
and prepositions should be capitalized if they are at the beginning of a Dialog 
or Window Title).

Text could us some re-wording.

Robin, please suggest correct wording, title and capitalization and then 
reassign back to default owner.

Comment 1

[jglick]

Attachment: screenshot of current dialog

Comment 2

[robinf]

Scott, Candice - can we dim the Delete button and the Edit>Delete Address Book
menu item in the AB window when the user has selected either the PAB or the CAB?
If we can't/won't do that, I can supply re-worded error message text. 

Comment 3

[scottputterman]

disabling would probably be the best way to go.

Comment 4

[jglick]

Agree.  If the CAB feature is turned off, can the user delete the CAB?

Comment 5

[Ninoschka Baca]

Trunk build 2002-02-26-3: WinMe
The Delete button is till enabled if the PAB or CAB is selected. After trying to 
either one of these address books then it reports
"You are not allowed to delete the Personal or Collected Addresses address 
books".

Note: After disabling the CAB feature, the Delete button is still enabled if the 
CAB is selected.

Comment 6

[robinf]

Reassigning to default owner, since we agree this requires an engineering change
(disabling Delete button when CAB or PAB is selected) rather than an error
message. Nominating for Mach V.

Comment 7

[Michael Buckland]

Discussed in 2/28/02 Mail & News bug meeting.  Decisions was to minus this bug.

Comment 8

[esther]

Per Bug triage, Changing summary to reflect the morfing of this bug. 
Old Summary "Error dialog when attempting to delete the CAB or PAB needs polish"
New Summary "Need to disable the Delete button & menu item Delete Address Book
when PAB or CAB is selected"

Comment 9

[Samir Gehani]

Mail triage team: nsbeta1+/adt3

Comment 10

[Cavin Song]

Reassigning.

Comment 11

[[e-mail]]

Attachment: Fix the delete key/menu/button only

In other words, this patch should make the dialog unnecessary.

Comment 12

[Stephen Donner [:stephend] Not actively reading bugmail]

Attachment: Patch removes .properties entry and some unnecessary checks

This patch removes:

* cannotDeleteMessage from addressBook.properties
* unnecessary checks for the PAB/CAB in AbDeleteDirectory (since we now disable
the menu items and therefore don't call this function all all for those types)
* brings the whitespace to 2-character spacing, which seems to be the prevalent
style in the rest of this file

Comment 13

[Stephen Donner [:stephend] Not actively reading bugmail]

Attachment: Same patch as above, with whitespace changes evident.

Comment 14

[David :Bienvenu]

combine these statements
+        if (selectedDir == kPersonalAddressbookURI)
+          return false;
+        if (selectedDir == kCollectedAddressbookURI)
+          return false;
into:
 if (selectedDir == kPersonalAddressbookURI || selectedDir ==
kCollectedAddressbookURI)
   return false;

+  if (parentRow == -1)
+    parentId = "moz-abdirectory://";
+  else	
+    parentId = dirTree.builderView.getResourceAtIndex(parentRow).Value;
parentId = (parentRow == -1) ? "moz-abdirectory://" :
dirTree.builderView.getResourceAtIndex(parentRow).Value;

this can also be simplified:
+  if (directory.isMailList) 
+    confirmDeleteMessage =
gAddressBookBundle.getString("confirmDeleteMailingList");
+  else
+    confirmDeleteMessage = 

+    confirmDeleteMessage = gAddressBookBundle.getString(directory.isMailList ?
"confirmDeleteMailingList" : "confirmDeleteAddressbook");

Comment 15

[[e-mail] (gone - use [e-mail] instead)]

Attachment: Incorporates David's style comments

Comment 16

[Stephen Donner [:stephend] Not actively reading bugmail]

Comment on attachment 135143 [details] [diff] [review]
Incorporates David's style comments

David / Neil, do either of you want to see the final diff -uw?

Comment 17

[Stephen Donner [:stephend] Not actively reading bugmail]

Comment on attachment 135143 [details] [diff] [review]
Incorporates David's style comments

David / Neil, do either of you want to see the final diff -uw?

Comment 18

[Stephen Donner [:stephend] Not actively reading bugmail]

Sorry, I meant a diff WITH the whitespace changes, which would just of course be
a regular unified diff without the -w switch.

Comment 19

[[e-mail]]

Comment on attachment 135143 [details] [diff] [review]
Incorporates David's style comments

I prefer to review a non-w diff because that saves me the trouble of backing
out the patch afterwards ;-)

Comment 20

[Stephen Donner [:stephend] Not actively reading bugmail]

Attachment: Full diff with whitespace changes included.

Comment 21

[Stephen Donner [:stephend] Not actively reading bugmail]

Fixed!  Thanks for the original patch, Neil!

Comment 22

[Joe Infla]

*** Bug 196123 has been marked as a duplicate of this bug. ***