73819 - Implement new memory cache for imap and news

Status: VERIFIED FIXED

(MailNews Core :: Networking, defect, P2)

Description

[Scott MacGregor]

Just a tracking bug. I need to tie mailnews into the new memory cache so we can
take the old cache out of the build.

Comment 1

[James Green]

Shouldn't this be OS/All?

Comment 2

[Darin Fisher]

mscott: let me know if you need any help making the transition.

Comment 3

[André Dahlqvist]

Is there any progress in this area?

Comment 4

[Scott MacGregor]

Attachment: Changes for imap and news to use the new cache

Comment 5

[Scott MacGregor]

Here are the diffs for getting imap and news to use the new cache. 

Remaining cleanup work:
1) I haven't tested david's offline code yet to make sure offline still works
2) I haven't swept through mailnews to make sure we aren't including any of the
old cache headers anywhere. 
3) This patch does not contain Darin's API changes from the other day. I have
some merge conflicts in nsNNTPProtocol and nsImapProtocol to clean up. I'll post
new diffs against a current tree as soon as I'm done. 

It seems to be working quite nicely for me so far!

Comment 6

[David :Bienvenu]

Cool - When you post the diffs against the tip, I'll try them out with offline
imap and news (though I'll have to checkin some changes in my tree first so
there will need to be an open tree).

Comment 7

[Scott MacGregor]

Attachment: Same patch, this time merged to the tip

Comment 8

[Scott MacGregor]

Okay here are the final diffs submitted for review. The big picture:
1) The big mess which was formerly known as AsyncOpen for nsImapProtocol and
nsNntpProtocol has been broken down into the following methods:
ReadFromLocalCache (for offline)
OpenCacheEntry
ReadFromImap/NewsProtocol
ReadFromMemCache

Open cache entry makes an async call to the imap or news cache session
requesting a cache entry for the url. If the callback comes back with an error
we default to ReadFromImap/NewsProtocol. If we successfully got a cache entry,
we then check the access flags. If we were given ACCESS_WRITE then we need to
write data into the cache entry. We set this up then call
ReadFromImap/NewsProtocol. If we were given ACCESS_READ then we call
ReadFromMemCache.

In addition both nsImapService and nsNNTPService now hang onto a nsICacheSession
object which is the cache session each of those modules is using. I added an
interface method to nsIImapService and nsIINntpService so I could retrieve the
appropriate cache session in the protocol instance.

Comment 9

[gordon]

Scott, remember you may also get ACCESS_READ_WRITE, in which case you can read 
the data from the cache as well.

Comment 10

[David :Bienvenu]

Looks good, Scott, but I really want to apply this patch myself and make sure
the offline stuff is working. I'm building now, and after the build finishes,
I'll apply the patch and try it out. I should be done before the tree opens this
afternoon.

Comment 11

[Scott MacGregor]

Attachment: forgot to include nsIMsgMailNewsUrl.idl change in the patch

Comment 12

[Scott MacGregor]

Okay I've landed the changes. Gordon, you guys should be good to go for turning
off the old cache and removing it from the build!!! yippee...

Comment 13

[[e-mail] (gone - use [e-mail] instead)]

The new code is in, and new bugs are to be filed seperately.  Marking verified.