Closed
Bug 73857
Opened 23 years ago
Closed 23 years ago
history should use the new outliner
Categories
(Core Graveyard :: History: Global, defect, P1)
Core Graveyard
History: Global
Tracking
(Not tracked)
VERIFIED
FIXED
mozilla0.9.3
People
(Reporter: cathleennscp, Assigned: bugzilla)
References
Details
(Keywords: perf, Whiteboard: fix in hand [nav+perf])
Attachments
(6 files)
67.15 KB,
patch
|
Details | Diff | Splinter Review | |
835 bytes,
image/gif
|
Details | |
841 bytes,
image/gif
|
Details | |
7.41 KB,
patch
|
Details | Diff | Splinter Review | |
9.73 KB,
patch
|
Details | Diff | Splinter Review | |
72.21 KB,
patch
|
Details | Diff | Splinter Review |
the new RDF outliner is in. we need to get history converted to use the new outliner
Comment 1•23 years ago
|
||
Anyone want to point me at some docs for this thing? or at least a starting place? the threadOutliner in mail looks a little too far from RDF to be of much use to me..:) I just need some really simple sample code (just a snippit here in the bug, not even a full XUL file) that shows: - how to set up a basic rdf-based outliner with #child-based relationships - how to set attributes on a row based on RDF property arcs - how to style a row based on these properties
Comment 2•23 years ago
|
||
waterson was using directory.xul on bug 71530 as the test of RDF outliner. That may be what you want to look at.
Comment 3•23 years ago
|
||
awesome! that's exactly what I needed.
Comment 4•23 years ago
|
||
BenG attached a xul demo of what he's working up to make bookmarks use outliner in bug 73508. given the once tight relationship btw history/bookmarks there might be something to leverage there.
nav triage team: Not a beta stopper, will revisit if this is the only decent solution to solve history performance problems. Marking nsbeta1-
Keywords: nsbeta1-
Assignee | ||
Comment 6•23 years ago
|
||
Alec, mind if I take this? Have it working in my tree.
Assignee | ||
Updated•23 years ago
|
Status: NEW → ASSIGNED
Priority: P2 → P1
Target Milestone: mozilla1.0 → mozilla0.9.1
Assignee | ||
Updated•23 years ago
|
Target Milestone: mozilla0.9.1 → mozilla0.9.2
Assignee | ||
Comment 7•23 years ago
|
||
Assignee | ||
Comment 8•23 years ago
|
||
Assignee | ||
Comment 9•23 years ago
|
||
Assignee | ||
Comment 10•23 years ago
|
||
Comment 11•23 years ago
|
||
} else { is the style established by alecf. I don't see a reason to change it. everything else looks fine.
Comment 12•23 years ago
|
||
Hm, well all this looks fine to me. I'm able to give (s)r= (whichever you need and whichever Alec/Waterson think is appropriate), but I'd like to hear from some people who've tested this on Mac and Linux first.
Assignee | ||
Comment 13•23 years ago
|
||
Cc'ing leaf to drive test builds.
Assignee | ||
Comment 14•23 years ago
|
||
[Just noticed that childTag's declaration should be in the following |if|...fixed)
Comment 15•23 years ago
|
||
looks good, but you're mucking with my tabs & spaces! that document CLEARLY has tab-width: 4 at the top of the file.
Assignee | ||
Comment 16•23 years ago
|
||
In history.js? Sure, I can keep it 4. But some of it was using 2 (the code Ben added, I think).
Assignee | ||
Comment 17•23 years ago
|
||
Comment 18•23 years ago
|
||
I am going to make mac testbuilds for this one
Comment 19•23 years ago
|
||
If you do experimental(opt.) builds or if this is just some js i can drop in lemme know and i'll be glad to test.
Assignee | ||
Comment 20•23 years ago
|
||
Assignee | ||
Comment 21•23 years ago
|
||
This affects mailnews (the columnpicker had to be changed to workaround bug 83906), cc'ing Seth.
Assignee | ||
Updated•23 years ago
|
Whiteboard: [nav+perf]
Assignee | ||
Updated•23 years ago
|
Whiteboard: [nav+perf] → fix in hand [nav+perf]
Assignee | ||
Updated•23 years ago
|
Target Milestone: mozilla0.9.2 → mozilla0.9.3
Assignee | ||
Comment 22•23 years ago
|
||
This was checked in.
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
Comment 23•23 years ago
|
||
suresh, more sample code for your AIM outliner work.
Updated•6 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•