Closed
Bug 74098
Opened 23 years ago
Closed 23 years ago
nsILDAPOperation.searchExt lacking attributes parameter
Categories
(Directory :: LDAP XPCOM SDK, defect, P2)
Directory
LDAP XPCOM SDK
Tracking
(Not tracked)
VERIFIED
FIXED
mozilla0.9.2
People
(Reporter: Paul.Sandoz, Assigned: dmosedale)
References
Details
(Keywords: perf, Whiteboard: [PDT+] have tested fix, r=, sr=, a=; need open tree)
Attachments
(4 files)
5.05 KB,
patch
|
Details | Diff | Splinter Review | |
5.11 KB,
patch
|
Details | Diff | Splinter Review | |
18.05 KB,
patch
|
Details | Diff | Splinter Review | |
17.87 KB,
patch
|
Details | Diff | Splinter Review |
The nsILDAPURL interface now has support for the return attributes parameter. It would be good if this could be used in conjuction with the nsILDAPOperation.seatchExt method which is currently lacking support for return attributes. In addition, as per comment by Dan Mosedale, it will optmize autocomplete searches.
Updated•23 years ago
|
Updated•23 years ago
|
Target Milestone: mozilla0.9.1 → mozilla0.9.2
Assignee | ||
Updated•23 years ago
|
Priority: P3 → P2
Comment 2•23 years ago
|
||
Comment 3•23 years ago
|
||
This patch doesn't actually enable the autocomplete session to limit the search results to a set of attributes. However, I've verified the functionality with a hardcoded set of attributes in the autocomplete, and it does indeed limit the results to the requested attributes. Dmose, review please. -- Leif
Comment 4•23 years ago
|
||
Assignee | ||
Comment 5•23 years ago
|
||
r=dmose@netscape.com
Summary: nsILDAPOperation.seatchExt lacking attributes parameter → nsILDAPOperation.searchExt lacking attributes parameter
Comment 6•23 years ago
|
||
mscott, can you SR this please? thanks, -- leif
Keywords: patch
Whiteboard: SR= requested on 6/12 from mscott
Comment 7•23 years ago
|
||
PDT+ per 6/12 mtg.
Whiteboard: SR= requested on 6/12 from mscott → [PDT+] SR= requested on 6/12 from mscott
Comment 8•23 years ago
|
||
sr=mscott
Comment 9•23 years ago
|
||
a= asa@mozilla.org for checkin to the trunk. (on behalf of drivers)
Blocks: 83989
Comment 10•23 years ago
|
||
Checked in. (Many thanks to srilatha for testing on Mac and PC) -- Leif
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
Assignee | ||
Updated•23 years ago
|
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Assignee | ||
Comment 11•23 years ago
|
||
Reopening, as there's still one piece left to do: change the autocomplete caller to do the right thing regarding this parameter.
Assignee | ||
Comment 12•23 years ago
|
||
Taking, since this final bit is in my code.
Assignee: leif → dmose
Status: REOPENED → NEW
Assignee | ||
Comment 13•23 years ago
|
||
I'm attaching a patch that gives the outputFormat parser the ability to work in two modes: one generates an autocomplete item (like the existing code in the tree does), and the other builds up an XPCOM array of the attributes needed by outputFormat. Whenever SetOutputFormat is called, this array is built up and cached in the session. Whenever SearchExt() is called, this array is used to limit the attributes requested.
Assignee | ||
Comment 14•23 years ago
|
||
Assignee | ||
Comment 15•23 years ago
|
||
Assignee | ||
Comment 16•23 years ago
|
||
Tiny tweak to the patch suggested by dougt eliminates unnecessary logic around freeing of mSearchAttrs.
Comment 17•23 years ago
|
||
r=
Assignee | ||
Comment 18•23 years ago
|
||
dougt said in chat that it's okay to use his stamp as sr=, so i'm gonna do that.
Whiteboard: [PDT+] → [PDT+] have sr=; need r=, a=
Assignee | ||
Comment 19•23 years ago
|
||
nsLDAPAutoCompleteSession patch has been tested on Mac, Windows, Linux debug builds, as well as commercial linux optimized builds.
Whiteboard: [PDT+] have sr=; need r=, a= → [PDT+] have tested fix, sr=; need r= (requested), a=
Comment 20•23 years ago
|
||
looks good, R=ducarroz
Assignee | ||
Updated•23 years ago
|
Whiteboard: [PDT+] have tested fix, sr=; need r= (requested), a= → [PDT+] have tested fix, r=, sr; need a=
Comment 21•23 years ago
|
||
a= asa@mozilla.org for checkin to the trunk. (on behalf of drivers)
Assignee | ||
Updated•23 years ago
|
Whiteboard: [PDT+] have tested fix, r=, sr; need a= → [PDT+] have tested fix, r=, sr=, a=; need open tree
Assignee | ||
Comment 22•23 years ago
|
||
Fix checked in.
Status: ASSIGNED → RESOLVED
Closed: 23 years ago → 23 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•