74381 - Patch for styleSheets object exposed in xul a doc

Status: RESOLVED FIXED

(Core :: DOM: CSS Object Model, defect)

Description

[Pete Collins (MDG)]

Hey Johnny, i'm filing this bug to track the patch to expose the styleSheets
object as a property in a xul document.

I need this property to continue development on Chameleon.

As soon as you review and i tighten up the code some, i will post the patch
here.

Thanks

--pete

Comment 1

[Pete Collins (MDG)]

Attachment: Patch to fix this. Needs review.

Comment 2

[Pete Collins (MDG)]

After this patch is reviewed and checked in, i would really like to clean things
up a bit and get rid of the compiler `index' warnings.

Thanks

--pete

Comment 3

[Pete Collins (MDG)]

Attachment: DIFF

Comment 4

[Pete Collins (MDG)]

Johnny can you `sv' this.

Thanks

--pete

Comment 5

[Keyser Sose]

Marking NEW so it will get looked at.

Comment 6

[Pete Collins (MDG)]

Attachment: Latest Patch tested on two systems

Comment 7

[Pete Collins (MDG)]

Attachment: a xul document test case

Comment 8

[Pete Collins (MDG)]

Attachment: css file used in test case

Comment 9

[Johnny Stenback (:jst)]

Final comments about the diff:

- Don't move the #include "nsDocument.h" in nsDocument.cpp.

- Extra whitespace added at line ~63 in nsDocument.cpp, remove.

- In nsDocument.cpp:

@@ -629,8 +555,10 @@
     NS_RELEASE(mListenerManager);
   }
 
-  NS_IF_RELEASE(mDOMStyleSheets);
   NS_IF_RELEASE(mNameSpaceManager);
+
+
mDOMStyleSheets = nsnull; // Release the stylesheets list.
+

  ^-- tab?

- nsDocument.cpp, line ~740, why rename psindex to psindx? That doesn't shadow
anything, does it?

- nsDocument.cpp:

@@ -751,10 +679,12 @@
   mStyleSheets.Clear();
 
   NS_IF_RELEASE(mListenerManager);
-  NS_IF_RELEASE(mDOMStyleSheets);
 
   NS_IF_RELEASE(mNameSpaceManager);
 
+
mDOMStyleSheets = nsnull; // Release the stylesheets list.
+
+
    ^--- More tabs?

- In nsXULDocument.h:

@@ -70,7 +72,7 @@
 
 class nsIAtom;
 class nsIElementFactory;
-class nsIDOMStyleSheetList;
+class nsDOMStyleSheetList;

There's no need to forward declare nsDOMStyleSheetList here, so removing the
nsIDOMStyleSheetList forward declaration is all you need to do here.

Change that, and check this in! r=[e-mail], sr=[e-mail]

(You do have checkin rights, right? If not let me know and I'll check this in
for you).

Thanks!

Comment 10

[Pete Collins (MDG)]

I'll make the changes now and check it in.

Thanks Johnny!

--pete

Comment 11

[Pete Collins (MDG)]

Attachment: final patch

Comment 12

[Pete Collins (MDG)]

Ok, checked in.

/tmp/cvsNxICG96615: 16 lines, 536 characters.
Checking in base/src/nsDocument.cpp;
/cvsroot/mozilla/content/base/src/nsDocument.cpp,v  <--  nsDocument.cpp
new revision: 3.289; previous revision: 3.288
done
Checking in base/src/nsDocument.h;
/cvsroot/mozilla/content/base/src/nsDocument.h,v  <--  nsDocument.h
new revision: 3.145; previous revision: 3.144
done
Checking in xul/document/src/nsXULDocument.cpp;
/cvsroot/mozilla/content/xul/document/src/nsXULDocument.cpp,v  <-- 
nsXULDocument.cpp
new revision: 1.398; previous revision: 1.397
done
Checking in xul/document/src/nsXULDocument.h;
/cvsroot/mozilla/content/xul/document/src/nsXULDocument.h,v  <-- 
nsXULDocument.h
new revision: 1.93; previous revision: 1.92
done


--pete

Comment 13

[Keyser Sose]

Marking FIXED.

Comment 14

[Johnny Stenback (:jst)]

Woo hoo! Thanks Pete!

Comment 15

[Pete Collins (MDG)]

Johnny, thank you bro!

;-)

--pete