7443 - Crash in nsDBFolderInfo::SetPropertyWithToken when select my IMAP server/folders

Status: VERIFIED FIXED

(MailNews Core :: Database, defect, P3)

Description

[lchiang]

Crash in nsDBFolderInfo::SetPropertyWithToken when select my IMAP server/folders

Seen in Win32 build, 6/1/99 build
TalkBack Incident ID: 9343756
No IMAP log available since I don't think I ever get to login.
David - I assigned to you since it looks like you are the author of this file
Here's a summary of steps I was doing.  I'll leave my system in this state so I
can try other things as you might suggest later.

1) Set up preferences to use IMAP.  This is the first time I've ever used my
profile so .msf files aren't created yet.
2) Start Messenger
3) Expand vadar server entry in folder pane
4) Select Inbox
5) Get new mail
6) My folders appear
7) Read some mail and exit
8) Start 4.51 Messenger
9) (using the same profile/directory that 5.0 used) Create new top level folder
and did some mail things (send, receive, read)
10) Exit 4.51
11) Start 5.0
12) Repeat steps 2-3.  Crash occurs.

Call Stack:    (Signature = nsDBFolderInfo::SetPropertyWithToken 525d8b61)

   nsDBFolderInfo::SetPropertyWithToken
[d:\builds\seamonkey\mozilla\mailnews\db\msgdb\src\nsDBFolderInfo.cpp, line 626]
   nsDBFolderInfo::SetInt32PropertyWithToken
[d:\builds\seamonkey\mozilla\mailnews\db\msgdb\src\nsDBFolderInfo.cpp, line 650]
   nsDBFolderInfo::SetFlags
[d:\builds\seamonkey\mozilla\mailnews\db\msgdb\src\nsDBFolderInfo.cpp, line 454]
   nsMsgDBFolder::ReadDBFolderInfo
[d:\builds\seamonkey\mozilla\mailnews\base\util\nsMsgDBFolder.cpp, line 133]
   nsImapMailFolder::UpdateSummaryTotals
[d:\builds\seamonkey\mozilla\mailnews\imap\src\nsImapMailFolder.cpp, line 644]
   nsImapMailFolder::GetDatabase
[d:\builds\seamonkey\mozilla\mailnews\imap\src\nsImapMailFolder.cpp, line 387]

Comment 1

[David :Bienvenu]

I don't know why running 4.51 would matter. Is it neccesary to cause this
problem?

Comment 2

[lchiang]

4.51 shouldn't matter.  I had to use it to create folders since 5.0 doesn't have
that feature in.

Removing my .msf file corrected this for me.  I have my bad.msf file around if
you want to see it although it shows 0 bytes.

Comment 3

[David :Bienvenu]

Ah, thanks, a 0 byte .msf file would explain a lot. What was the bad msf file
named? (Inbox.msf?) Or vadar.msf?

Comment 4

[lchiang]

vadar.msf

Comment 5

[David :Bienvenu]

Thanks, thought it might be that - there's not supposed to be a vadar.msf but if
there was one, I would imagine it would be empty.

Comment 6

[David :Bienvenu]

this worked fine for me, despite the 0 byte vadar (or tintin) .msf file. Maybe I
need to delete the whole tintin directory...

Comment 7

[lchiang]

I can try to reproduce this again on Monday in the latest build.  It has been a
few builds since I last tried this (renamed my vadar.msf file).

Comment 8

[lchiang]

I cannot reproduce this crash any longer in today's build.  I will use 5.0 for
some real mail usage and see what happens.

Comment 9

[David :Bienvenu]

musta been one of those fixes I checked in from
France via Minitel.

Comment 10

[David :Bienvenu]

marking fixed to get off m7 list.

Comment 11

[lchiang]

Talkback incident: 10024600

Using 6/15 release build, I got the same problem.
1) Installed new build
2) Removed registry file
3) Started apprunner; new profile created
4) Started apprunner and brought up Messenger w/default prefs50.js. Exited
5) Copied my prefs (which is for my IMAP acct and News server) into the profile
directory
6) Started apprunner; crash occurs when the Messenger window opens.  Crash in
the same place as previously.

David tracked it down to an empty .msf file in my IMAP directory.  This .msf
file corresponded to one of my subfolders.

Comment 12

[David :Bienvenu]

I still can't reproduce this on my machine. I'll try bulletproofing the code,
but I don't know what's going on here.

Comment 13

[lchiang]

Try this:
1) In 4.x, create a folder hierarchy where you are subscribed to the child
folders, but not the parent folders.
2) Start Messenger in 5.0. You'll notice that the parent/child folders don't
show up (subj of another bug). Exit.
3) Back in 4.x, subscribe to the parent folder
4) In 5.0, do you crash now?  Perhaps step 2 is where an empty .msf file of the
parent folder came from?

This all started when I noticed that one of my folders didn't show up and turned
out to be unsubscribed.  That's when I started playing around and creating
folders.

Comment 14

[David :Bienvenu]

I still can't reproduce this - moving off m7. I checked in some bullet-proofing,
but I have no idea if it works or not.

Comment 15

[David :Bienvenu]

seems to be fixed, according to Lisa. I guess the bullet-proofing did the job.

Comment 16

[lchiang]

I am going to wait until the next build before I mark this verified.  It appears
to work in today's (6/16) Win32 build.

Comment 17

[lchiang]

I don't see this crash in the 6/17 build either.  I'll mark it verified since
your bullet proofing works.

Correcting to M7 since the fix is in M7 and not M8.