74801 - nsWBContentListener should go away

Status: VERIFIED FIXED

(Core Graveyard :: Embedding: APIs, defect)

Description

[Judson Valeski]

Currently nsWebBrowser uses an intermediary nsIURIContentListener to hook up the
embeddor w/ the underlying nsIURIContentListener chain. This layer is extraneous
as the embeddor can be hooked directly up to the underlying
nsIURIContentListener (currently nsDSContentListener). The existing
nsWBContentListener is doing nothing more than fowarding the exact same calls
that the underlying nsDSContentListener is forwarding. The existing
nsWBContentListener was added due to a regression last summer and the regression
has since been fixed.

Comment 1

[Judson Valeski]

Attachment: removes nsWBContentListener from the build and from use.

Comment 2

[Christopher Blizzard (:blizzard)]

r/sr=blizzard

Comment 3

[Christopher Blizzard (:blizzard)]

oops

Comment 4

[Conrad Carlen (not reading bugmail)]

Good. The WBURIContentListener is, in most methods that it impls, just dead
wood. Except in IsPreferred(), where it actually does something it does the
wrong thing (says it's not preferred for text/plain) r=ccarlen

Comment 5

[Judson Valeski]

fix is in. thanks all.

Comment 6

[Christopher Blizzard (:blizzard)]

There are some lingering bugs from this checkin.

Comment 7

[Christopher Blizzard (:blizzard)]

Attachment: fix call to docshell

Comment 8

[Christopher Blizzard (:blizzard)]

The call down to the docshell has to get a GetInterface, not a QueryInterface. 
Because of that the call can return nsnull so it doesn't require an assertion. 
In the case where the GetInterface() to the docshell returns null the setter
will return NS_ERROR_FAILURE.  Maybe it should return NS_ERROR_NO_INTERFACE?

Comment 9

[Christopher Blizzard (:blizzard)]

Attachment: patch without else/return before shaver bugs me about it

Comment 10

[Mike Shaver (:shaver -- probably not reading bugmail closely)]

sr=shaver

Comment 11

[Judson Valeski]

n, I like the NS_ERROR_FAILURE return. NO_INTERFACE in these methods, to me, is
more info than the caller should see.

*thanks* for finding this.

r=valeski

Comment 12

[Judson Valeski]

I went ahead and checked this in. thanks blizzard.

Comment 13

[Christopher Blizzard (:blizzard)]

No problem.

Comment 14

[Christopher Blizzard (:blizzard)]

*** Bug 75101 has been marked as a duplicate of this bug. ***

Comment 15

[Michael Dunn]

Correction: Changing QA contact for the Embed API bugs to David Epstein.

Comment 16

[David Epstein]

no trace of nsWBContentListener or WBURIContentListener in lxr.mozilla.org.