7496 - pressing return doesn't submit form

Status: VERIFIED FIXED

(Core :: DOM: Core & HTML, defect, P3)

Description

[Mike Pinkerton (not reading bugmail)]

Go to yahoo and type something into the search field at the top of the page.
Press return. The Comm4.x behavior is that the form is submitted, and in fact
this even works on MacMozilla, but on windows nothing happens. You have to click
the button to submit the form.

It appears that the return is being filtered out by the native text widget on
win32 (and maybe linux) so that the keypress never gets to Gecko.

Comment 1

[karnaze (gone)]

Reassing to Tom. This use to work. The enter event must be getting caught
somewhere.

Comment 2

[Mike Pinkerton (not reading bugmail)]

hyatt and i noticed that the keypress is getting caught in the window proc of the
text widget: (nsTextWidget.cpp):

LRESULT CALLBACK nsTextWidget::TextWindowProc(HWND hWnd, UINT msg, WPARAM wParam,
LPARAM lParam)
{
    // Filters the "ding" when hitting the return key
    if (msg == WM_CHAR) {
      long chCharCode = (TCHAR) wParam;    // character code
      if (chCharCode == 13 || chCharCode == 9) {
        return 0L;
      }
    }

    return nsWindow::WindowProc(hWnd, msg, wParam, lParam);
}

This code eats the return entirely. It never makes it out of the native window
proc.

Comment 3

[Eli Goldberg]

<Please note bug #7081.>

Comment 4

[joki (gone)]

I believe someone (rod?) fixed this with the gfx stuff.

Comment 5

[leger]

cpratt, can you verify ASAP please.

Comment 6

[cpratt]

Pressing Return does submit the from at Yahoo! using the 1999092508 build
(Windows 98).