75187 - platformGlobalOverlay.xul in xpfe/communicator/resources content is obsolete

Status: RESOLVED FIXED

(Core :: XUL, defect, P3)

Description

[Andrew Thompson]

Currently we have 2 copies of platformGlobalOverlay.xul one under xpfe/global and 
one under xpfe/communicator.

I believe the later is unused and should be deleted (its already not being 
maintained). Search lxr for platformGlobalOverlay.xul for the evidence.

BTW, I don't think the same is true for platformDialogOverlay.xul. Both copies of 
those still seem to be in use, which is probably a problem in and of itself.

Comment 1

[Peter Trudelle]

So Blake's recent changes were not really needed?  ->ben, who apparently 
created these files.

Comment 2

[Andrew Thompson]

No, blake sensibly updated the right versions, the one like:
xpfe/global/resources/content/<platform>/platformGlobalOverlay.xul

He ignored those like:
xpfe/communicator/resources/content/<platform>/platformGlobalOverlay.xul

I believe the later ones are obsolete based on a lxr search. 

Comment 3

[Ben Goodger (use ben at mozilla dot org for email)]

Attachment: patch to remove files

Comment 4

[Boris Zbarsky [:bzbarsky]]

Is this patch/bug still relevant?  There seems to be no GlobalOverlay anymore...
(except on OS2)

Comment 5

[Simon Paquet [:sipaq]]

There's no platformGlobalOverlay.xul anymore. See
http://lxr.mozilla.org/mozilla/find?string=platformGlobalOverlay.xul and
http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=all&file=platformGlobalOverlay.xul&filetype=match&sortby=Date&date=all&cvsroot=%2Fcvsroot


Marking FIXED.