Closed
Bug 759061
Opened 12 years ago
Closed 12 years ago
nsINIParser.cpp fails to compile on mingw
Categories
(Core :: XPCOM, defect)
Tracking
()
RESOLVED
FIXED
mozilla15
People
(Reporter: jacek, Assigned: jacek)
Details
Attachments
(1 file)
|
1.03 KB,
patch
|
TimAbraldes
:
review+
|
Details | Diff | Splinter Review |
That's because of usage of assignment statement for initializing, which is not compatible with GCC. See https://bugzilla.mozilla.org/show_bug.cgi?id=733708#c3 for detailed explanation.
Attachment #627642 -
Flags: review?(tabraldes)
|
||
Comment 1•12 years ago
|
||
Comment on attachment 627642 [details] [diff] [review] fix v1.0 Review of attachment 627642 [details] [diff] [review]: ----------------------------------------------------------------- Sorry about the delay; I've been out of town. This fix looks good, thanks for taking care of this!
Attachment #627642 -
Flags: review?(tabraldes) → review+
|
Assignee | |
Comment 2•12 years ago
|
||
Thanks for the review. https://hg.mozilla.org/integration/mozilla-inbound/rev/fe129d98513e
Target Milestone: --- → mozilla15
|
||
Comment 3•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/fe129d98513e
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•