76203 - hrule icon doesn't show up in Show All Tags mode

Status: VERIFIED DUPLICATE of bug 88036

(Core :: DOM: Editor, defect, P4)

Description

[Kathleen :Brade]

* create a new blank editor document
 * insert an hrule
 * double-click on the hrule and make it not have 3-d shading
 * click ok in the hrule dialog
 * go to the Show All Tags mode
 * notice that there isn't an icon for the hrule

Comment 1

[Charles Manske]

Mac only? (I'm still building today, but I know I've seen this work on Windows
last week.)

Comment 2

[Kathleen :Brade]

I see this on Windows builds (NS6 as well as a recent debug build).  Make sure
you do each step as described in the initial report.

Comment 3

[Charles Manske]

The yellow "HR" icon doesn't seem to be displayed at left edge of the HR elements
frame. Thus when "noshade" is used, the gray HR hides the icon.

Comment 4

[Charles Manske]

Adding "depends" status -- this will be fixed when 76244 is fixed.
Nothing we can really do in Editor code.

Comment 5

[Daniel Glazman (:glazou) (not active in Mozilla any more)]

Attachment: patch v1.0

Comment 6

[Daniel Glazman (:glazou) (not active in Mozilla any more)]

Proposing patch for this bug. I have completely rewritten EditorAllTags.css to
take advantage of generated content. To do that, I have modified the selection
so clicking on a generated content selects the element that generated it, and
patched XULPopups so double-clicking and right-clicking on generated content
in AllTags mode works.

Torture tests by torturers needed ;-)

Comment 7

[David Hyatt]

So the popup listener check is too slow (since you're groveling through all the 
kids to see if you're contained in the list).  We should talk to jst about 
adding a bit or something to indicate that content is generated.

Comment 8

[Charles Manske]

Daniel: Be sure to talk to mjudge about the issue of finding generated content;
he has already explored the problem and ran into the performance issues that
hyatt notes.

Comment 9

[Daniel Glazman (:glazou) (not active in Mozilla any more)]

I think that bit indicating generated content makes sense : there are a number of
cases where we need that information... I am open to any suggestion as soon as I
have a way, reasonably fast so hyatt does not put a spell on me, to know that a
given node is generated by its parent node.

Comment 10

[Charles Manske]

We decided to postpone switching to using "before" strategy for All Tags mode
so we could address selection of generated content and other issues, correct?
Changing milestone to 1.0.

Comment 11

[Daniel Glazman (:glazou) (not active in Mozilla any more)]

reassigning bug to myself

Comment 12

[Daniel Glazman (:glazou) (not active in Mozilla any more)]

New code in hand with sync with hyatt's changes in style engine + detection of
generated content reusing mjudge code (see bug 82993). Hyatt : that solves the
problem you raised about XULPopupListener :-)

About EditorAllTags.css :

                 | bytes  |  lines  |  CSS rules
-----------------+--------+---------+--------------
existing file    | 23309  |  812    |  96
-----------------+--------+---------+--------------
my file          |  4766  |  202    |  26
-----------------+--------+---------+--------------

Comment 13

[Daniel Glazman (:glazou) (not active in Mozilla any more)]

Removing the "[behavior]FIX IN HAND, need r=, sr=" status whiteboard ; I have no
fully stable fix in hand and do not seek for reviews for the moment

Comment 14

[Daniel Glazman (:glazou) (not active in Mozilla any more)]

*** This bug has been marked as a duplicate of 88036 ***

Comment 15

[sujay]

verified.