76343 - OS/2 - chardet.dll crash

Status: VERIFIED FIXED

(Core :: Internationalization, defect)

Description

[Dmitry Kubov]

Mozilla/5.0 (OS/2; U; Warp 4.5; en-US; rv:0.8.1+) Gecko/20010417

Enable Russian charset autodetection and visit www.mozilla.org for example to crash.

2001-04-11 was fine, its broken on 04-16

Comment 1

[Dmitry Kubov]

bug 67576 regression?

Comment 2

[Andreas Becker]

Changing qa contact to [e-mail].  Marina, can you confirm this bug?

Comment 3

[marina]

i don't see it happening on NT , is it OS/2 specific?

Comment 4

[Mike Kaply [:mkaply]]

The crash appears to be Os/2 specific, but the problem does not.

I traced the trap and it appears that what is happening is that mObserver in 
nsDetectionAdapter is getting overriden.

Essentially the new for mObserver and a later new are returning the same 
memory, 
so when RawBuffer access mObserver it is trash.

I can't even find where mObserver is supposed to get freed in this code. It's 
not a COMPtr.

Comment 5

[Roy Yokoyama]

Humm, I ment to change the mObserver to use nsCOMPtr; but
I forgot to do it.

class nsDetectionAdaptor : ... {
-     nsMyObserver* mObserver; 
+     nsCOMPtr<nsMyObserver> mObserver; 
}

I'll attach the patch to see if this bug gets fixed in few minutes.
Can someone try the patch on OS/2?

Comment 6

[Roy Yokoyama]

Attachment: using nsCOMPtr<>

Comment 7

[Dmitry Kubov]

This does not help. Still crashing.

Comment 8

[Dmitry Kubov]

It traps inside nsDetectionAdaptor::RawBuffer

    if(mObserver) 
       mObserver->SetNotifyByReload(PR_TRUE);

Comment 9

[Roy Yokoyama]

I am seeing a memory override at the start up.  The memory allocation of
nsCOMPtr<nsMyObserver> in nsDetectorAdaptor::nsDetectorAdaptor() is
causing the memory problem.    Investigating...

Comment 10

[Roy Yokoyama]

Attachment: Using NS_IMPL_QUERY_INTERFACE2

Comment 11

[Roy Yokoyama]

We finally figure this out.
It's the #ifdef IMPL_NS_IPARSERFILTER was causing the problem.
IMPL_NS_IPARSERFILTER was not defined in nsCharDetModule.cpp where
nsDetectionAdaptor was constructed.

To only fix this bug, we can define IMPL_NS_IPARSERFILTER in
the top of nsCharDetModule.cpp.

Better yet, I attached the patch to remove the IMPL_NS_IPARSERFILTER
and did little clean up.

mkaply :can you assign this bug to me and test the patch (04/19/01 19:38)
on OS/2?

Comment 12

[Mike Kaply [:mkaply]]

This latest patch fixes the trap.

We would really like this for 0.9.

Thanks

Comment 13

[Roy Yokoyama]

There is a bug with the same patch (76152) which will be checked into 0.9
once /sr=xxxxx.

The bug is occuring in Linux; however, it's the similar bug.
The patch fixes both.  I am going to make 76152 to be depend on this bug.

Comment 14

[Roy Yokoyama]

Patch in 76152 should fix this bug as well. Please verify.

Comment 15

[Dmitry Kubov]

Crash fixed.

There is another bug - chardetection preference not saved. At least I see
nothing about current setting after starting browser. Should I open new bug?

Comment 16

[Roy Yokoyama]

Please add a new bug if it's not already filed.
Thanks