76388 - Add Offline items to Account Central for IMAP accounts.

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Message Display, defect, P2)

Description

[laurel]

Tracking bug fpr UI implementation for IMAP Offline items in Account Central.

Reference the spec at: http://www.mozilla.org/mailnews/specs/offline/#Central

Account Central should have offline items added per spec for IMAP accounts (AOL
accounts excluded from this feature).  Currently calls for addition of:
1.  Offline Settings link (takes user to the account settings offline panel for
that IMAP account)
2.  Checkbox for INBOX auto-synch on Get Mail feature - (related back end bug 74621)

Not sure who is actually adding this -- will Eclient?

Comment 1

[David :Bienvenu]

I think bhuvan would probably do this. Scott?

Comment 2

[racham]

Yes. This is my bug (& any future AccountCentral bugs to start with). Taking 
this one from Seth.

Jennifer, Are we going to have Inbox synch checkbox on the mail AccountCentral 
page..? Why are we not having in the AccountManager offline panel on per server 
basis ? Is this feature intended only for default Account ? In either case, I 
guess moving it inside the offline paenl will be better. Let me know your 
thoughts.

bhuvan

Comment 3

[scottputterman]

I think Jennifer was coming up with a design to move the download checkbox from
Acct Central to the offline panels in the Acct Manager.

When the offline panels land, we can add this.

Comment 4

[laurel]

My mistake, guess everything I know is wrong.  Seems someone has decided to
change this since we all met and agreed on where the feature would be placed.
Follow the moving target!

Comment 5

[jglick]

Changing the location of the ""Automatically download my Inbox..." pref is not a 
done decision. It was just an idea that Scott and I discussed informally after 
the meeting.  Offline is such a confusing feature to start with, that we 
starting talking about how we might make it better. Scott wanted me to spec out 
some alternate designs that we might look at as a group.  We wouldn't change 
anything without the group consensus. I'm sorry for the confusion.

Comment 6

[jglick]

Attachment: Simple Offline checkbox in Acct Settings

Comment 7

[jglick]

Above is a screenshot of a proposed design.  This would function exactly as 
previous discussed (in the issues meeting and summarized in the spec) except 
that instead of appearing on the Acct Central panel, the checkbox for Simple 
Offline appears on the Offline "Acct Settings" panel.  When clicking on "Offline 
settings" on the Acct Central page, this panel is opened. Also, from the 
File: Offline flyout menu, there should be a way to open this panel.  

The reasons for moving this checkbox to Acct Settings instead of Acct Central: 1 
- There is more room on the Acct Settings panel to better explain this feature 
to users (what are the results of checking this box). 2 - It is grouped with the 
other Offline settings to give users a better overall picture of the feature. 3 
- The checkbox is sorta out of place on Acct Central. There are no other 
checkboxes on Acct Central. It is a panel of links to common features/actions, 
not a place to define settings. 4 - Having a link from Acct Central to Offline 
Settings make this feature easy to get to for users who are interested in 
offline, but not in the face of users who are not interested in offline. Offline 
and IMAP are still more common with more experienced users.

Please provide feedback on this idea.  As noted above, this is a proposal only, 
nothing with be changed unless there is a group consensus.

Comment 8

[timeless]

I'd recommend that offline and disk space be separate panels, otherwise your 
window is too big relative to the preferences dialog which I think Ben wants 
set as the maximum initial dimensions for comfortable fit of a dialog @ 640x480

Comment 9

[scottputterman]

It's hard to tell whether it will fit, but it looks like it might to me
(compared to the HTML Domains one that doesn't).

Comment 10

[Håkan Waara]

Jennifer Glick, is it possible to "crop" or in any way shorten the texts in that
pref?

We should have as short sentences as possible, in order to make chances higher
that the user will actually *read* it.

Thanks

Comment 11

[jglick]

Robin, can you take a look at the wording on this panel? Thanks.

Comment 12

[Matthew T (active 1999-2002)]

UI review of the screenshot:

`Offline' is an adjective. It is not a noun. None of the following are 
acceptable English:
*   `Offline & Disk Space' [this implies `offline space and disk space', which
    is obviously not what you mean]
*   `Offline enables you to download ...'
*   `Simple Offline automatically downloads ...'
*   `Enable Simple Offline'
*   `When I create new folders, select them for offline'.

Thankfully, most of that doesn't need rewriting; it should just be deleted. 
There is no need to go into entire *paragraphs* -- in a dialog, of all
places! -- trying to teach the user a whole new `Simple Offline' buzzword (an 
ungrammatical buzzword, to boot), when you can just have a checkbox for what 
the feature actually *does*.

Finally, the `[ ] Automatically select new folders for offline use' checkbox 
would make more sense in the `Choose Folders' dialog, not in the main prefs 
panel.

+-Offline Folders--------------------------------------------------+
|                                                                  |
| [/] _Download messages in my Inbox so I can read them offline    |
|                                                                  |
| [ ] Download messages in _other folders  ( _Choose Folders ... ) |
+------------------------------------------------------------------+

+-When downloading messages for offline use:-----------------------+
|                                                                  |
| [ ] Delete the local copies of messages which are at least       |
|     [ 30]H days old                                              |
| [ ] Only download messages which are smaller than                |
|     [ 50]H kilobytes                                             |
| [ ] Compact* folders when it will save at least                  |
|     [100]H kilobytes                                             |
+------------------------------------------------------------------+

* This wording subject to change when I find out what `compacting' really
  means.

Now, isn't that so much simpler?

Comment 13

[jglick]

The purpose of this feature is to try and have a more simple (but limited) 
version of offline for less experienced users.  Kevin Murray can explain the 
rational behind this. 

The standard Offline feature works as follows: User first selects the folders 
they want available for offline, before going offline user downloads messages 
locally. When going back online, user synchs/plays back any actions they 
performed to messages while offline.  To average users, this is a lot of steps 
that aren't very apparent.   

The goal of the simplified Offline feature (I agree the name isn't good) was to 
provide a method for users to be able to select one checkbox and have mail do 
the right thing to make sure their messages were available when they were 
offline (no going through all the steps mentioned above).  Since this would be 
too time consuming to do for all folders, it was suggested that we make this 
available for the Inbox only.  Mail would automatically do the 
downloading/playback for the user for the Inbox only.  (In reality, clicking the 
"Get Msg" button is what causes this "automatic" behavior.)

As is apparent from the screenshot, its very difficult to try and explain this 
distinction. I wonder if we are creating more confusion by adding this. And I 
wonder if we should focus our efforts on making offline more easy to use all 
around, than trying to provide a simple vs advanced version.

As for mpt's suggestions, yes there are less words, but i'm not sure its any 
better at explaining this feature and the difference between options. 

I was referring to "Offline" as the name of a feature, as in the "Offline 
feature".  The text can be changed to "The Offline feature..." if that is more 
appropriate. Robin is checking with an Editor on this one.

"Download messages in _other folders" shouldn't be a checkbox. You shouldn't 
have to turn offline "on".  Its always "on", its just a matter of selecting 
folders.  

Comment 14

[jglick]

Attachment: alternate idea with "offline feature" and less words

Comment 15

[robinf]

Our editor agrees that we should use "offline" as a modifier (e.g., the offline
feature, offline settings, etc.). So for the title of the dialog (and category),
I suggest we just use "Offline Settings" instead of "Offline & Disk Space". I'd
prefer to use "Offline Settings & Disk Space" but I don't think there's enough
room in the left column. I'd also change the first group box title to "Offline
>>Settings<<".

As for the first check box, I'd like to suggest this wording: "Automatically
download my Inbox messages when I go offline."

For the second check box: "When I create new folders, select them for offline
>>use<<."

Side note: We will be implementing a Help button in the Account Settings dialog,
so users can look there for more info on how to use the offline features. 

Comment 16

[David :Bienvenu]

unless I'm getting my settings confused, that's not what the check box for the
inbox does. It downloads the messages for offline use whenever you get new mail
or select the inbox, not when you go offline.

Comment 17

[Håkan Waara]

Providing sentences, and even paragraphs with information on how to use a
"feature" or pref is generally not good UI. A pref should, generally, be
self-explanatory and if it isn't then you should make it so or remove it,
because if the user can't understand what it does or why it's useful only by
looking at it - then you have a serious UI problem.

The "Offline" groupbox (and the overall UI) is better in your new screenshot,
but still not ideal.

Now, here comes some more nits: 

1. The first paragraph is imho not too useful. It explains what "the offline
feature" is and that you can access your msgs while offline if using it. I
suggest you either remove this or instead use something like: "You can can
download your messages locally so that they are available when you are
offline.".  Make it short, don't use marketing expressions ("..feature enables
you to..") just to impress or whatever.  :)

2. The second sentence explains how to use the "Select" button. Ok, this text
should be moved to somewhere around the "Select" button where it explains it and
belongs.

3. As for the Disk Space groupbox, I suggest you remove the first text there
altogether; you don't need to explain what Offline + Disk Space means. It was
easy to understand the prefs there, without the text.

Comment 18

[scottputterman]

I completely disagree that we can't put explanatory text in the account settings
dialog.  I do not think that these concepts are obvious to many users and just
because we know what everything does doesn't mean that everyone else will.  I
think this is a fine place to put that explanation given that this is where the
user will be setting up their offline settings.  I don't disagree that we should
do our best to get the point across in as few words as possible.

Comment 19

[David :Bienvenu]

trust me, the offline concepts are far from obvious and could use all the
explaining we've got space for.

Comment 20

[Matthew T (active 1999-2002)]

Yes, but you *haven't* got space for it. Both Jennifer's mockups use quite a 
small font (Tahoma 8pt, I think), but they're still 497 pixels tall (including 
title bar). As Ben pointed out in bug 70392, that's just too high. You need to 
fit in fewer than 460 pixels (including title bar), for the prefs dialog to be 
able to fit on a 640*480 display containing a Windows taskbar, Mac OS menu bar, 
or GNOME Panel. And that's before we get on to the psychological effects of a 
dialog covering your entire screen, leaving you without visual context.

I appreciate that you are trying to make the offline feature more 
understandable so that more people can use it, and that's excellent. But I 
believe adding explanatory paragraphs to the dialog will make it *less* 
understandable, not more. I don't claim that my wording is any better at 
explaining the options than Jennifer's; but whereas Jennifer's first mockup 
uses an average of 26.0 words to explain each control in the `Offline' section, 
my mockup uses an average of 6.3 words to explain each control. That's surely 
going to make a difference to the number of people who will bother reading the 
words at all.

See also:
*   <http://joel.editthispage.com/stories/storyReader$85>
*   <http://www.useit.com/alertbox/whyscanning.html>

> "Download messages in _other folders" shouldn't be a checkbox. You shouldn't
> have to turn offline "on".  Its always "on", its just a matter of selecting
> folders.  

This checkbox exists partly for symmetry with the first checkbox, but it also 
makes like easier when you're on the road. I use offline IMAP, and often when 
I'm short of time I just want to synchronize my Inbox rather than synchronizing 
all of the 24 folders which I am subscribed to. I'd much rather turn off one 
checkbox for this (the `Download messages in other folders' checkbox), and turn 
that one checkbox back on again later, than go into a dialog and turn off 23 
checkboxes and then have to turn those same 23 checkboxes on again later.

Comment 21

[David :Bienvenu]

If you're just synchronizing your inbox, all you have to do is bring up the
properties dialog for the inbox and do a download now (when the UI is checked in
- which should be soon, I hope). When you reconnect, operations will be
automatically played back when you open your inbox.  So I don't see why
"Download messages in _other folders" is needed.

Comment 22

[jglick]

Thanks everyone for your feedback. I tried to incorporate the suggestions into 
an updated screenshot. Attachment to follow.

Comment 23

[jglick]

Attachment: IMAP Offline & Diskspace

Comment 24

[scottputterman]

My only concern about the wording is that the Inbox checkbox and the Select
Folder dialog work differently.  The Inbox checkbox will download messages as
they come in and will always be available.  All other folders chosen through the
Select Folder dialog will only be available if the user reads a message (on a
per message basis)or does a sync(for the whole folder).  I feel that their
should be some distinction between the two features.

Comment 25

[jglick]

"Use the "Select" button to choose..." text can be moved back to the top which 
will group everything together instead of making the 2nd checkbox seemed grouped 
with the first checkbox and not related to text below?

Comment 26

[scottputterman]

Let's just try jglick's suggestion from 5/7 and see how it goes.  If there's the
confusion I'm worried about, we can change the wording later.

Comment 27

[racham]

Attachment: patch to add offline items in the account manager and accountcentral

Comment 28

[racham]

All wording changes (dtd) are already approved by jglick.

Comment 29

[(not reading, please use [e-mail] instead)]

how will changes to the offline level persist across sessions?
or, is this value defined by the isp rdf data?

Comment 30

[(not reading, please use [e-mail] instead)]

Attachment: update patch

Comment 31

[(not reading, please use [e-mail] instead)]

whoops, ignore that patch.  wrong bug.

Comment 32

[racham]

Attachment: updated patch to persist/derive on the offline supoort level

Comment 33

[racham]

Attachment: Also the offline.xul file (missed in the last patch)

Comment 34

[racham]

Attachment: Complete & most updated patch

Comment 35

[racham]

Please consider the most recent patch as the final patch (for reviews). 
Here are the things it does :

* Introduce a genaralized procedure to query any given server for it's offline 
support level.
* Add OfflineSettings item to the AccountCentral based on server's offline 
support capability
* Add a new checkbox item "Make the messages in my Inbox available when I am 
working offline" and have the checkbox reflect the pref that does it for IMAP 
server panels
* Make sure that AOL accounts (or any ISP for that matter who do not want 
offline support) does not display offline settings item in AccountManager
* Remove the following items from IMAP panel as they are not supported in the 
backend (this is essentially bug 79561). Thought it's better to clean that up as  
I am there in the code anyway. Diane, please let me know if it is OK with you.
  - "When I create new folders select them for offline use"
  - "Remove messages bodies older than X days"

I just realized that I still need to add diffs for mailnews.js file from mozilla 
tree and diffs for *.rdf files from ns tree to reflect ISP preferences. They are 
coming up.

Comment 36

[racham]

Attachment: mailnews.js diffs

Comment 37

[racham]

Attachment: isp rdf files' diffs (ns)

Comment 38

[Diane Sun]

I notice that you removed both: 
- "When I create new folders select them for offline use"
- "Remove messages bodies older than X days"

The first one is still in the spec and I have implemented in bug 79561.  The 
second one is removed.

Comment 39

[racham]

David told me that ("When I create new folders select them for offline use") is 
not implemented in the backend either..

Comment 40

[David :Bienvenu]

go ahead and put the UI in - I'll implement the backend later.

Comment 41

[David :Bienvenu]

r=bienvenu

Comment 42

[Blake Ross]

Please don't intentionally add non-working UI until you can point out other 
professional applications that have equally blatant oddities.

Also, there are some spacing issues in the patch, e.g.:

+    <checkbox iscontrolcontainer="true" hidable="true" hidefor="pop3,nntp" 
id="offline.downloadBodiesOnGetNewMail" 
+        wsm_persist="true" label="&makeInboxMsgsAvailable.label;" 
accesskey="&makeInboxMsgsAvailable.accesskey;"/>
+
+	<separator class="thin" hidable="true" hidefor="pop3,nntp"/>
+
+	<html iscontrolcontainer="true" hidable="true" 
hidefor="pop3,nntp">&selectButtonDesc.label;</html>

No need to attach a new patch for that, but racham, would you mind attaching a 
screenshot of the (changed) UI?  UI changes are now expected to be reviewed 
partly based on screenshots.

Comment 43

[David :Bienvenu]

I'm sorry; I meant leave it in. the UI is already in and bhuvan was removing it.
I would think it's OK to leave it in in this particular case since UI freeze is
coming up. 

Comment 44

[racham]

Should I keep 

  - "Remove messages bodies older than X days"

also then. Let me know about both of them.

If that is the case, I will have to generate new screenshots. Otherwise, I have 
a set of screenshots ready to be posted.

bhuvan

Comment 45

[David :Bienvenu]

"Remove messages bodies older than X days" will not be implemented for IMAP in
this release, and should be removed for imap servers.

Comment 46

[scottputterman]

maybe for 0.9.1 we could disable the items that don't work but will eventually
be implemented in 0.9.2?

Comment 47

[racham]

ok..I will get rid of that one.

Let me post the screenshots I already have. Will post the IMAP offline panel 
screenshot once after rearranging the code.

Comment 48

[racham]

Attachment: image#1 - AccountCentral Page with Offline settings added

Comment 49

[racham]

Attachment: image#2 - Offline panel for POP account

Comment 50

[racham]

Attachment: image#3 - Offline Panel for news account

Comment 51

[racham]

Attachment: image#4 - ISP without offline support (from aol.rdf)

Comment 52

[racham]

Attachment: image#5 - ISP with offline support (based on nswebmail.rdf)

Comment 53

[racham]

Please note that the offline panel items in the image#5 will be changed once the 
IMAP panel item issues are settled. IMAP panel screenshot posted then shall 
reflect the state for the panel in this image(#5) also.

Comment 54

[scottputterman]

Bhuvan,

What are the remaining issues for IMAP?  You removed the remove after X days
pref and then I think you should put back in and disable the Create new folders
for offline use pref.

Comment 55

[racham]

That's all. Those were the only issues.

OK then.

I am going to remove

- "Remove messages bodies older than X days"

and keep & disable

- "When I create new folders select them for offline use"

Screenshot coming up..

Comment 56

[racham]

Attachment: image#6 - Offline IMAP panel

Comment 57

[jglick]

Looks good.  If still possible:

1. Change text on POP offline dialog to: "Messages are stored locally on your 
computer. To save disk space:" to match structure of IMAP and News offline 
dialogs.

2. Break IMAP and News dialogs into "Offline" and "Disk Space" groupboxes, 
images to follow.

Comment 58

[jglick]

Attachment: Offline IMAP

Comment 59

[jglick]

Attachment: Offline News

Comment 60

[jglick]

Attachment: Offline POP

Comment 61

[(not reading, please use [e-mail] instead)]

I'm ok with everything except your changes to GetOfflineSupportLevel() and
mailnews.js. you've added defaults for webmail and aol mail to mailnews.js, but
by default mozilla users can't use those, only Netscape 6.x users can.

you did this:

+pref("mail.server.default.offline_support_level", -1);
+pref("mail.server.default.aol_offline_support_level", 0);
+pref("mail.server.default.netcenter_offline_support_level", 1);

the first one is correct, and you've followed convention. (given a pref, replace
the hostname with default.)

I'd remove the 2 others, and put them in ns-mailnews.js in the commercial tree 
as:

pref("default_offline_support_level.imap.mail.aol.com", 0);
pref("default_offline_support_level.imap.mail.netcenter.com",1);

then, fix GetOfflineSupportLevel() to do this:
if the offline support pref level is not set for the server, try
"default_offline_support_level" + hostname. if that doesn't fail use it, if that
fails, use the default "mail.server.default.offline_support_level" value.

that gives us an extensible way to get this to work based on hostname.

one last comment, instead of casting your XPIDLCStrings, use .get().

(const char *)foo -> foo.get()

Comment 62

[(not reading, please use [e-mail] instead)]

one last comment, don't use 0,1,2 for the levels
since this is an int pref, it doesn't give us any room for error.

(we can't put anything between 1 and 2)

I've been bit by this before.  do something like 0,10,20.  if we ever need to 
add some intermediate level, we can without worrying about existing users.

Comment 63

[racham]

Seth,

thanks for all your comments. Will make a new patch and post it.

Comment 64

[Blake Ross]

Some brief comments about the UI, because I hate laptops:

- Where possible, we need to group related items more intelligently.  Right now 
most of the contents of the panels are just in one big groupbox (without a 
title).

- I don't understand parts of the Disk Space UI.  Specifically, how can things 
like "Download only unread messages" and "Download only messages since [ ]" be 
checkboxes?  Or why are there three radiobuttons for "Keep ..." and one checkbox 
for "Keep only ..."?  How is that even possible?  Perhaps this is due to my own 
ignorance in this area, but this UI seems overly complex.  Also, those controls 
should generally be indented under the labels, but really they should have their 
own groupboxes.

- A textbox that is dependent on a checkbox or radiobutton should only be 
enabled when the checkbox or radiobutton is.

- The text after a textbox in a radiobutton or checkbox seems misaligned in some 
cases.  I suspect that clicking it won't check the radiobutton or checkbox, 
also.  Toolkit needs to provide ways to handle this better (a different bug).

- There are some wording problems (e.g. the inconsistent placement of "only" in 
"Keep only unread messages" and "Remove message bodies only older than [ ] 
days" or redundant usage of "... when you are working offline")

- Two checkboxes generally does not justify the need for a new pref panel (the 
spec doesn't even seem to suggest that there are more on the way), although I 
see that it's for consistency among the two mail types.

- I still don't see the reason of leaving in broken UI, even (especially) if 
it's permanently disabled, considering you already had a patch to remove it.

I defer to Matthew and Ben to decide which of these issues (or any that they 
have) should be fixed before checkin, and which can be handled in a new bug, 
taking into account the desire to get this in for 0.9.1.

Comment 65

[timeless]

my comments will probably overlap w/ others, i'm sorry.

wrt attachment 34975 [details] Is it possible to just download headers?
wrt attachment 35015 [details] How does compacting folders relate to download time? -- If 
this is about compacting server folders please indicate.

Offline text messages are inconsistent.

Instead of a disk space group box in the disk space panel, please create 
separate download time and clean up groupboxes.
* Move compact folders into the second group.

your radio buttons have two different appearances.

Move up and move down buttons should be disabled for non accounts. Otherwise 
you confuse the user.

Comment 66

[David :Bienvenu]

Please don't disable the ui for newly created folders. You're just going to have
to enable it again when the backend is checked in. Which it just was.

Re Blake's confusion about the checkboxes - the ui is correct as is. We use
checkboxes for settings that are orthogonal, and radio buttons for things that
are mutually exclusive.  Why do you want to prevent the user from only
downloading unread messages less than 20 days old? Why would you insist that
they chose only unread messages, or only messages less than 20 days old? That
doesn't make sense to me.

Comment 67

[Blake Ross]

I still think it's confusing to check "Keep all messages" and "Keep only unread 
messages".  How am I keeping all messages if I'm only keeping my unread ones?

Comment 68

[racham]

David, Jennifer,

I think the situation Blake mentioned is probably the way many will look at it. 
Are we missing any sub-headings there...

I have the updated patch with new gifs and incorporating some code changes 
suggested by Seth. New patches and images coming up..

I know there are couple of issues left with UI and there are bugs already 
assigned to diane to address the same which are TFVed 0.9.2 now. I can't address 
all them here but trying to incorporate as many.

bhuvan

Comment 69

[racham]

Attachment: mozilla diffs

Comment 70

[racham]

Attachment: ns diffs

Comment 71

[racham]

Attachment: new IMAP Panel snapshot (per jennifer's screenshots)

Comment 72

[racham]

Attachment: new POP panel

Comment 73

[David :Bienvenu]

No, 4.x looked the same and didn't get any complaints. The radio button choice
"Keep all messages" would perhaps more accurately be labelled "don't keep
messages based on arrival date or number of message" but I don't think that will
fit in the dialog. The purpose of that choice is as a negative of the other two
radio button choices. I'm not sure if there's a more succinct UI for that other
than three radio buttons. Basically, the user can choose A, B, or none of the above.

However, that last "Remove messages older than 20 days" line should read remove
"message bodies older than 20 days". The other choices refer to message headers,
not offline bodies.

Comment 74

[racham]

Attachment: new NEWS panel

Comment 75

[racham]

Posted patches just so we can make progress on reviews and to incorporate any 
quick changes we may need to.

Comment 76

[scottputterman]

I think the panels look good. We should get this in.  I agree that some of the
wording may need to be rethought, but I don't think it should hold up checkin of
the code, especially given that this patch doesn't add the wording in question.
Plus, this patch makes the news panel look better than the current build so it
would be nice to see this get in. 

Comment 77

[jglick]

blake, I agree the wording could use some work. :-)  Could we start another bug 
for that?  Could you write in that bug what you think is confusing, why you 
think it confusing, and any suggestions you have?  Please cc me and Robin and 
mpt and timeless would be good moz folks to be involved.

Comment 78

[(not reading, please use [e-mail] instead)]

sr=sspitzer

I agree, land these improvements and log new bugs for additional improvments /
cleanup.

Comment 79

[racham]

Here is the last set of simple UI changes I have added in the news panel 
(thought could get these done as tree is yet to open) after talking to David & 
Jennifer.

Following text elements (associated with 2 check boxes) in the disk space panel 
of NEWS

* Download only unread messages
* Download only messages since X days ago

are changed to

* Download only unread message bodies
* Download message bodies for messages since X days ago

respectively.

UI snapshot coming up..

Comment 80

[racham]

Attachment: Latest NEWS offline panel

Comment 81

[Blake Ross]

Wording was just a small subset of what I mentioned.  It bothers me that we 
can't fix some of the other easy issues while we're adding the UI, so the new 
bugs should really be targetted at 0.9.2.  We agreed not to prevent checkins if 
didn't make the current UI worse, and I can't access a build, but I'm assuming 
this checkin doesn't do that.  So I'm okay with checking it in given that the 
more significant UI issues are fixed for 0.9.2, but I think it's a mistake.

Comment 82

[racham]

Fix checked in.

Filed a new bug 81753 to track all the UI issues discussed here and more. Thanks
everyone for reviews and updates.

Marking fixed. 

Comment 83

[grylchan]

Tested 200105304 on NT 4.0, 2001053009 on MAC OS 9.0.4, and
2001053008 on Red Hat 7.0: linux 2.2.

I am just verifying that the presence of a "offline settings" link on 
Account Central and the new pref, on Offline & Disk space, "Make
the messages in my inbox available when I am working offline"
is visible and working.

Verified the following:
Offline Settings link
 - clicking the link "Offline settings" on Account Central
   does take you to the "account settings" for that particular
   mail account. Note there is a bug 82197 filed that says
   clicking on the link should take you to Offline & Disk Space 
   pref rather than to "account settings"
 - spelling and link actually works
 - placed under Advanced features like the spec says
Make the messages in my Inbox available when I am working offline
 - spelling and placement match the spec
 - when selected, messages are downloaded whenever you 'get new mail' or
   click on the inbox folder
 - only the inbox is downloaded
 - setting this preference has no affect on the "select items for offline
   usage" dialog window/the inbox doesn't have a checkmark to be downloaded
   they are 
 - messages are downloaded and available to read when offline

I did not verify all the different UI changes to Offline & Disk Space pref.
I will make any UI comments in bug 81753

Marking as verified

Comment 84

[Diane Sun]

Currently, in am-offline.xul there two some ids with the same names:  
"offline.notDownload",   "offline.notDownloadMin", they appear in two different 
titleboxes which causes the prefrence " Do not download messages locally that 
larger than "  NOT saved for  IMAP.

Comment 85

[Diane Sun]

and nntp