764426 - Disallow slashes in document slug field in forms

Status: RESOLVED FIXED

(developer.mozilla.org Graveyard :: Editing, defect)

Description

[Les Orchard [:lorchard]]

Slashes in page URLs are significant in the parent / child relationship in the document hierarchy. So, as part of field validation, slashes should be disallowed in the editable portion of document editing forms.

So, a document at /en-US/docs/CSS/CSS_Reference/Foo should allow the "Foo" part to be edited. But, if a submission changes "Foo" to "Foo/Bar", that should be rejected by form validation.

For bonus points: Not sure how to finesse this, UI-wise, but a slug edit of "Foo/Bar" probably means the user wants to create a sub-page. Maybe we can word the error message or somehow guide the user toward the sub-page creation feature?

Comment 1

[Les Orchard [:lorchard]]

Depending on bug 764431, this bug may be a moot point for editing if slug changes get changed to a more formal "Move this page" command. We should at least disallow slashes in the slug for a newly created page.

Comment 2

[[github robot]]

Commits pushed to master at https://github.com/mozilla/kuma

https://github.com/mozilla/kuma/commit/0779d6c1ea407b454487bd44ab6e0012f4de0164
fix bug 764426 - Prevent slashes in slugs from form

https://github.com/mozilla/kuma/commit/6459cc10014a5475f9708b50897cfc7e51e6b07d
Merge pull request #273 from darkwing/disallows-slashes-slug-764426

fix bug 764426 - Prevent slashes in slugs from form