76450 - inital focus on page load has regressed

Status: RESOLVED FIXED

(Core :: XUL, defect, P1)

Description

[saari (gone)]

load google.com, shift-tab twice to get into urlbar, type. 
On mac you don't see a caret until you type, but then it works.
On windows, you don't get a caret or characters *unless* you click in the 
google search field and then do tabbing.
On linux, it just doesn't work at all.

Comment 1

[saari (gone)]

On my win2k box I am now seeing that it doesn't work unless you click in the URL
bar first. Clicking in the content's text box doesn't matter. Once you've
clicked in the URL bar it works fine until you try another page. It *will*
continue to work if you just reload the same page. 

Comment 2

[saari (gone)]

Okay when it doesn't work, ESM::GetNextTabbableContent returns null for next
tabbable content. It looks like mCurrentFocus doesn't get nulled out
appropriately when we first set focus to the text field in the content away from
the URL bar, so when we try to set it back, it hits the new focus ==
mCurrentFocus check and bails.

When it does work, that check doesn't get hit and all is well.

Comment 3

[Ben Goodger (use ben at mozilla dot org for email)]

*** Bug 76614 has been marked as a duplicate of this bug. ***

Comment 4

[saari (gone)]

Attachment: And just to prove a point, here is a totally gross hack that happens to fix the problem in what might actually be a valid way

Comment 5

[saari (gone)]

Attachment: a cleaner patch

Comment 6

[saari (gone)]

*** Bug 76009 has been marked as a duplicate of this bug. ***

Comment 7

[saari (gone)]

Attachment: one more time, the last one had changes I didn't want

Comment 8

[selmer (gone)]

Need to test 31809 against this fix, last comment in that bug says this one
regressed it.

Comment 9

[saari (gone)]

the 2 above patches are bogus, ignore them

Comment 10

[saari (gone)]

Attachment: A good patch this time, tested and sr=hyatt or r=me, which ever way you want to look at it

Comment 11

[David Hyatt]

[s]r=hyatt

Comment 12

[Mike Pinkerton (not reading bugmail)]

i would prefer if this was made into a function since i'm sure we do this 
elsewhere, but i've been told not to taunt happy fun ball. r=pink.

Comment 13

[chris hofmann]

a=drivers

Comment 14

[saari (gone)]

fixed