766957 - Browser toolbar should disappear in Reader Mode

Status: RESOLVED DUPLICATE of bug 716403

(Firefox for Android Graveyard :: General, defect)

Description

[Ian Barlow (:ibarlow)]

Entering Reader Mode should put users into a full screen view of their article, and should hide the Firefox Title bar.

We can explore ways of restoring the title bar, either by:

* Tapping on the screen (reveals bottom toolbar and title bar)
* Pulling down from the top 1/3 of the screen (which is an interaction we want to try in regular web content as well, as a way to scroll the header off screen and quickly access it again)

Comment 1

[Lucas Rocha (:lucasr)]

(In reply to Ian Barlow (:ibarlow) from comment #0)
> Entering Reader Mode should put users into a full screen view of their
> article, and should hide the Firefox Title bar.
> 
> We can explore ways of restoring the title bar, either by:
> 
> * Tapping on the screen (reveals bottom toolbar and title bar)
> * Pulling down from the top 1/3 of the screen (which is an interaction we
> want to try in regular web content as well, as a way to scroll the header
> off screen and quickly access it again)

My initial feeling about this is that we should simply implement the general behaviour for the header (second bullet point here) and use it in the Reader as is.

Ideally, we shouldn't need to special-case the Reader in any way as putting the web content at the center without distractions is a goal for Fennec as a whole not just the Reader.

Comment 2

[Ian Barlow (:ibarlow)]

> My initial feeling about this is that we should simply implement the general
> behaviour for the header (second bullet point here) and use it in the Reader
> as is.

Agreed. I outlined the desired header behaviour in bug 716403, and indicated this should apply both in standard browsing mode and in reader mode.

Comment 3

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

(In reply to Ian Barlow (:ibarlow) from comment #2)
> Agreed. I outlined the desired header behaviour in bug 716403, and indicated
> this should apply both in standard browsing mode and in reader mode.

Should this be marked as a dup of bug 716403 then?

Comment 4

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

(In reply to Michael Comella (:mcomella) from comment #3)
> Should this be marked as a dup of bug 716403 then?

Or actually, I'm not sure exactly how Reader Mode works and if inserting the changes for regular sites will affect Reader Mode. In the case that it doesn't affect Reader Mode (which I would consider not a dup), we should probably make it dependent on bug 716403 to make sure we don't forget about it.

Comment 5

[Lucas Rocha (:lucasr)]

(In reply to Michael Comella (:mcomella) from comment #3)
> (In reply to Ian Barlow (:ibarlow) from comment #2)
> > Agreed. I outlined the desired header behaviour in bug 716403, and indicated
> > this should apply both in standard browsing mode and in reader mode.
> 
> Should this be marked as a dup of bug 716403 then?

My understanding is that the behaviour for reader mode should be the same than for any other page. Tweaking the behaviour just for reader would probably mean that we're doing it wrong. Closing as dup.