76990 - Hidden window is visible in Mac OS X dock window menu, breaks focus

Status: VERIFIED FIXED

(SeaMonkey :: UI Design, defect)

Description

[Andrew Thompson]

Click and hold the mouse on Fizzilla in the Dock on Mac OS X (Apr 17 build). The
Window meny that comes us includes the Mac "Hidden Window". It shouldn't be visible.

If you select the hidden window, focus gets confused and you must switch in and
out of Mozilla before you can use any windows again.

Comment 1

[Henri Sivonen (:hsivonen)]

*** Bug 84455 has been marked as a duplicate of this bug. ***

Comment 2

[Henri Sivonen (:hsivonen)]

This now WFM. Lordpixel, does it work for you, too?

Comment 3

[Not interested in Mozilla any more]

The hidden window is still visible in the doc Mozilla windows list when using
Mozilla 0.9.2 release.
OS Build : MacOS X 10.0.4 4Q12

Comment 4

[Ari]

When the hidden window is created, it passes the window type
eWindowType_invisible to nsMacWindow::StandardCreate(). The following code could
be added to this function to prevent the hidden window from being visible in the
Dock menu:

#if TARGET_CARBON
if(mWindowType == eWindowType_invisible) {
  ::ChangeWindowAttributes(mWindowPtr, kWindowNoAttributes,
                           kWindowInWindowMenuAttribute);
}
#endif

This function must, of course, be called after the window is created.

Comment 5

[sairuh (rarely reading bugmail)]

pink?

Comment 6

[Mike Pinkerton (not reading bugmail)]

that is so sexy. i love open source.

Comment 7

[Mike Pinkerton (not reading bugmail)]

Attachment: remove appropriate attribute when window invisible

Comment 8

[Simon Fraser [no longer active]]

Comment on attachment 53815 [details] [diff] [review]
remove appropriate attribute when window invisible

sr=sfraser

Comment 9

[Mike Pinkerton (not reading bugmail)]

landed on trunk. thanks for the patch!

Comment 10

[Greg K.]

Verified using FizzillaMach/2003-05-25-03-trunk. The hidden window doesn't
appear in the Dock menu.