77455 - wire up LDAP autocomplete to compose window

Status: VERIFIED FIXED

(MailNews Core :: Composition, defect)

Description

[Dan Mosedale (:dmosedale, :dmose)]

Comment 1

[Dan Mosedale (:dmosedale, :dmose)]

Attachment: proof-of-concept patch

Comment 2

[Dan Mosedale (:dmosedale, :dmose)]

OK, I've just attached a proof of concept patch which hard-codes in the
directory server rather than getting it from prefs.  Note that it also hardcodes
in the sizeLimit, filterTemplate, and outputFormat, none of which are yet (at
the time of this writing) used by nsLDAPAutoCompleteSession.

To use this, click on the "Show dependency tree" link, and apply the patches
from all the unresolved bugs that the dependency tree points to (there should be 7).

Then, apply the patch from this bug (it goes on top of one of hewitt's patches).
 After rebuilding, LDAP autocomplete should work.

Comment 3

[Dan Mosedale (:dmosedale, :dmose)]

Actually, there's no patch in 69700 itself, so there are only patches from 6
bugs to apply before applying the patch in this one.

Comment 4

[Srilatha Moturi]

Attachment: this will look up preferences for directory server

Comment 5

[Srilatha Moturi]

With this you can autocomplete in compose window using the directory server set 
in the preferences. 

Comment 6

[Srilatha Moturi]

Ccing Bhuvan for review

Comment 7

[Srilatha Moturi]

ccing Seth for sr

Comment 8

[Jean-Francois Ducarroz]

only one comment:

+        try {
+          prefs = Components.classes['@mozilla.org/preferences;1'];
+          prefs = prefs.getService();
+          prefs = prefs.QueryInterface(Components.interfaces.nsIPref);
+        }
+        catch (ex) {
+          dump("failed to get prefs service!\n");
+          prefs = null;

Don't need to add this code as the global variable prefs is alreay initialized and ready to bu used!
If you remove those line, R=ducarroz

Comment 9

[(not reading, please use [e-mail] instead)]

please attach a new patch, with ducarroz's suggestions.

Comment 10

[(not reading, please use [e-mail] instead)]

ducarroz / srilatha:

> document.getElementById('msgRecipient#1').setAttribute("searchSessions",
"addrbook ldap")

does that mean we only autocomplete on the first addressee only?

Comment 11

[Srilatha Moturi]

No. msgRecipient#1 is just a textbox id

Comment 12

[(not reading, please use [e-mail] instead)]

sr=sspitzer

Comment 13

[Jean-Francois Ducarroz]

We use the first recipient row, which is the only one declared in xul, as a template for the other one created 
dynamically. Therefore, yes, it will work...

Comment 14

[Srilatha Moturi]

Attachment: Version2 of the patch

Comment 15

[Jean-Francois Ducarroz]

R=ducarroz

Comment 16

[Srilatha Moturi]

Just checked it in.

Comment 17

[yulian chang]

Verified with 2001051604 Wins build.

Comment 18

[Ian Neal]

I'm not sure that this is still working, see bug 121415

Comment 19

[Ian Neal]

Reopening as it seems something may have regressed this fix.

Comment 20

[Ian Neal]

Bug 121415 is likely to have not been caused by a regression to this fix ->
resolving as fixed again

Comment 21

[Mark Banner (:standard8)]

Verifing the closure. Mozilla/5.0 (X11; U; Linux i686; en-GB; rv:1.9a1)
Gecko/20050815 SeaMonkey/1.0a