77674 - assert if I click on the column picker in the history sidebar channel

Status: RESOLVED FIXED

(Core Graveyard :: History: Global, defect, P2)

Description

[(not reading, please use [e-mail] instead)]

assert if I click on the column picker in the history sidebar channel

and no picker shows up.

it looks like we're doing getelementbyid of ""

nsDebug::Assertion(const char * 0x0205e81c, const char * 0x0205e80c, const char 
* 0x0205e7cc, int 2990) line 286 + 13 bytes
nsDebug::WarnIfFalse(const char * 0x0205e81c, const char * 0x0205e80c, const 
char * 0x0205e7cc, int 2990) line 392 + 21 bytes
nsXULDocument::GetElementById(nsXULDocument * const 0x04e9d978, const nsAString 
& {...}, nsIDOMElement * * 0x0012d330) line 2990 + 39 bytes
DocumentGetElementById(JSContext * 0x04e90830, JSObject * 0x04fc2b30, unsigned 
int 1, long * 0x02be7f70, long * 0x0012d414) line 1005 + 26 bytes
js_Invoke(JSContext * 0x04e90830, unsigned int 1, unsigned int 0) line 813 + 23 
bytes
js_Interpret(JSContext * 0x04e90830, long * 0x0012e194) line 2706 + 15 bytes
js_Invoke(JSContext * 0x04e90830, unsigned int 1, unsigned int 2) line 830 + 13 
bytes
js_InternalInvoke(JSContext * 0x04e90830, JSObject * 0x04fcc1f0, long 82777800, 
unsigned int 0, unsigned int 1, long * 0x0012e32c, long * 0x0012e2bc) line 902 
+ 20 bytes
JS_CallFunctionValue(JSContext * 0x04e90830, JSObject * 0x04fcc1f0, long 
82777800, unsigned int 1, long * 0x0012e32c, long * 0x0012e2bc) line 3334 + 31 
bytes
nsJSContext::CallEventHandler(nsJSContext * const 0x04e83680, void * 
0x04fcc1f0, void * 0x04ef16c8, unsigned int 1, void * 0x0012e32c, int * 
0x0012e328, int 0) line 940 + 33 bytes
nsJSEventListener::HandleEvent(nsIDOMEvent * 0x07d83054) line 154 + 64 bytes
nsEventListenerManager::HandleEventSubType(nsListenerStruct * 0x05594820, 
nsIDOMEvent * 0x07d83054, nsIDOMEventTarget * 0x05588938, unsigned int 4, 
unsigned int 2) line 1035 + 19 bytes
nsEventListenerManager::HandleEvent(nsIPresContext * 0x04e76860, nsEvent * 
0x0012f440, nsIDOMEvent * * 0x0012f34c, nsIDOMEventTarget * 0x05588938, 
unsigned int 2, nsEventStatus * 0x0012f734) line 1201 + 39 bytes
nsXULElement::HandleDOMEvent(nsXULElement * const 0x05588930, nsIPresContext * 
0x04e76860, nsEvent * 0x0012f440, nsIDOMEvent * * 0x0012f34c, unsigned int 2, 
nsEventStatus * 0x0012f734) line 3675
nsXULElement::HandleDOMEvent(nsXULElement * const 0x05588270, nsIPresContext * 
0x04e76860, nsEvent * 0x0012f440, nsIDOMEvent * * 0x0012f34c, unsigned int 2, 
nsEventStatus * 0x0012f734) line 3692 + 53 bytes
nsXULElement::HandleDOMEvent(nsXULElement * const 0x055881f0, nsIPresContext * 
0x04e76860, nsEvent * 0x0012f440, nsIDOMEvent * * 0x0012f34c, unsigned int 1, 
nsEventStatus * 0x0012f734) line 3692 + 53 bytes
PresShell::HandleEventInternal(nsEvent * 0x0012f440, nsIView * 0x00000000, 
unsigned int 1, nsEventStatus * 0x0012f734) line 5495 + 47 bytes
PresShell::HandleEventWithTarget(PresShell * const 0x04ec1ce0, nsEvent * 
0x0012f440, nsIFrame * 0x02ac7984, nsIContent * 0x055881f0, unsigned int 1, 
nsEventStatus * 0x0012f734) line 5468 + 22 bytes
nsEventStateManager::CheckForAndDispatchClick(nsEventStateManager * const 
0x055b4440, nsIPresContext * 0x04e76860, nsMouseEvent * 0x0012f840, 
nsEventStatus * 0x0012f734) line 2313 + 61 bytes
nsEventStateManager::PostHandleEvent(nsEventStateManager * const 0x055b4448, 
nsIPresContext * 0x04e76860, nsEvent * 0x0012f840, nsIFrame * 0x02ac7984, 
nsEventStatus * 0x0012f734, nsIView * 0x04ec0450) line 1412 + 28 bytes
PresShell::HandleEventInternal(nsEvent * 0x0012f840, nsIView * 0x04ec0450, 
unsigned int 1, nsEventStatus * 0x0012f734) line 5515 + 43 bytes
PresShell::HandleEvent(PresShell * const 0x04ec1ce4, nsIView * 0x04ec0450, 
nsGUIEvent * 0x0012f840, nsEventStatus * 0x0012f734, int 1, int & 1) line 5422 
+ 25 bytes
nsView::HandleEvent(nsView * const 0x04ec0450, nsGUIEvent * 0x0012f840, 
unsigned int 28, nsEventStatus * 0x0012f734, int 1, int & 1) line 377
nsViewManager::DispatchEvent(nsViewManager * const 0x04ec05f0, nsGUIEvent * 
0x0012f840, nsEventStatus * 0x0012f734) line 2055
HandleEvent(nsGUIEvent * 0x0012f840) line 68
nsWindow::DispatchEvent(nsWindow * const 0x04ec0314, nsGUIEvent * 0x0012f840, 
nsEventStatus & nsEventStatus_eIgnore) line 704 + 10 bytes
nsWindow::DispatchWindowEvent(nsGUIEvent * 0x0012f840) line 725
nsWindow::DispatchMouseEvent(unsigned int 301, nsPoint * 0x00000000 {x=??? 
y=???}) line 4028 + 21 bytes
ChildWindow::DispatchMouseEvent(unsigned int 301, nsPoint * 0x00000000 {x=??? 
y=???}) line 4273
nsWindow::ProcessMessage(unsigned int 514, unsigned int 0, long 589970, long * 
0x0012fc10) line 3009 + 24 bytes
nsWindow::WindowProc(HWND__ * 0x0050035a, unsigned int 514, unsigned int 0, 
long 589970) line 959 + 27 bytes
USER32! 77e71820()

Comment 1

[Alec Flett]

Attachment: fix

Comment 2

[Alec Flett]

well, it seems that the observes= system has stopped copying the id= attribute
from the observing node. this is probably a good thing.. fortunately, the
observes= attribute actually /is/ the id of the node I'm looking for, so I'm
just switching to using it instead of .id
I also make sure there /is/ and observes= attribute, because the column picker
should not trigger a sort.

Comment 3

[(not reading, please use [e-mail] instead)]

r or sr=sspitzer

Comment 4

[Alec Flett]

fix is in.