Closed Bug 77969 Opened 23 years ago Closed 21 years ago

ftp(HTML) - HTML correctness

Categories

(Core Graveyard :: Networking: FTP, defect)

Product:
Core Graveyard
Component:
Networking: FTP
Type:
defect
Priority:
Not set
Severity:
trivial

Tracking

(Not tracked)

Status:
VERIFIED FIXED
Milestone:
Future

People

(Reporter: tenthumbs, Unassigned)

References

Details

(Keywords: helpwanted)

Attachments

(1 file)

mockup
5.09 KB, text/html
Details 
There's no <pre> tag but there is a </pre> tag at the end of the file so the
listing is in a proportional font. Not a big deal, though.
sr=darin.
fix checked in.
Status: NEW → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
With an 0428 build, tidy gets upset because the entire table is wrapped
inside the <pre> tag. I guess the "right" thing is to use css; something
like:

  <head>
     ...
    <style type="text/css">
      TD {font-family: monospace; }
    </style>
  </head>

although the family may well be wrong.

You're all going to hate me but I'm going to reopen this bug. Sorry.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Severity: minor → trivial
Target Milestone: --- → Future
reassigning to bbaetz@cs.mcgill.ca.
Assignee: dougt → bbaetz
Status: REOPENED → NEW
My dirviewer rewrite doesn't help this, but there's no point in changing it
until that semi-rewrite lands.
Depends on: 78148
Keywords: helpwanted
QA Contact: tever → benc
clarified summary + qawanted - my layout skills are limited. perhaps someone can 
qa the final change for correctness?
Keywords: qawanted
Summary: Slightly incorrect HTML in ftp directory listing → ftp(HTML) - HTML correctness
with CSS this should be easy.
bbaetz: if you don't mind, I'd like to try fix this.
Feel free.
before I do any
Assignee: bbaetz → _basic
oops!

Is there any preference as to use <style> </style> in <head> to style the page
or inline style="" to style individual elements? The difference is that if
style="" is used, the style will get copied when a copy/paste operation is done,
where as using <style></style> will not.
Use an external style sheet with a resource: url, so that it can be themed.
Attached file mockup — 
here is a mockup of what I intend to do. Do take a look at the HTML source.
Would like some feedback.
assigning to nobody
Assignee: basic → nobody
should this go back to bbaetz?
There was an FTP/HTML re-write that I verified this weekend. Can someone who is
layout-smart look at the newer HTML source, and update this bug w/ a list of
things that need to be changed?
Test URL: http://ftp.mozilla.org/pub/mozilla/nightly/latest/
HTML of FTP directory listings still horked. win32 2002101508:

HTML:
[   ] mozilla-win32-instal..> 16-Oct-2002 10:09  10.7M  
[   ] mozilla-win32-instal..> 16-Oct-2002 10:05   214k  
[   ] mozilla-win32-talkba..>                        -  
[   ] mozilla-win32.zip                              -  

FTP:
File: mozilla-win32-installer-sea.exe  10963 KB 10/16/2002 10:09:00
File: mozilla-win32-installer.exe        215 KB 10/16/2002 10:05:00
File: mozilla-win32-talkback.zip       10982 KB 10/16/2002 10:08:00
File: mozilla-win32.zip                10742 KB 10/16/2002 10:06:00
The HTML validates for some time already, I just tested to make sure (with
1.4beta). As for comment 15, this is about the html generated by the browser not
the web server. Try ftp://ftp.mozilla.org/pub/mozilla/nightly/latest/
Status: NEW → RESOLVED
Closed: 23 years ago → 21 years ago
OS: Linux → All
Hardware: PC → All
Resolution: --- → FIXED
VERIFIED/fixed: thanks, basic.
Status: RESOLVED → VERIFIED
Keywords: qawanted
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: