77974 - CSS2 blocker: Alternate cursor should load if URI is broken

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect, P2)

Description

[Skewer]

Procedure: Load a document which specifies a cursor and move your mouse over the
affected element.

Expected: Element will load the first possible cursor in a comma-broken list.
Hopefully all of the CSS2 elements should be supported, and if reasonably
possible, Mozilla should try to fetch a .cur file specified in the URL value and
display it (at least on the Windows platform), reasonably possible defined as
able to connect and download the uncorrupted file without timing out.

Actual: Mozilla appears to ignore the cursor property entirely if more than one
value is specified on the list. Instead the default cursor for that element is used.

Also, Mozilla does not load cursors specified as a URL, even if they are not
part of a list.

Proposal: We need this browser to be, at the very least, 99.9% compatible with
CSS1 and CSS2 if it's going to live up to its expectations. This should be fixed
to behave as documented at the following URL:

http://www.w3.org/TR/REC-CSS2/ui.html#cursor-props

If I have time I will get a test page up this weekend to demonstrate this
behavior (unless someone knows of such a test that already exists).

Appears on: Build 20010426 Win98

Comment 1

[Johnny Stenback (:jst)]

I don't see how this is at all related to DOM style, reassigning to the Style
System component.

Comment 2

[Skewer]

Added URL of test page:

http://skewer.hypermart.net/csstest/

This page has several different tests for compatibility with CSS2's cursor
property. Mozilla fails most of these tests.

Comment 3

[Skewer]

Can anyone confirm this behavior? In theory, the CSS interpreter should be the
same for all platforms, so anyone who has the privs is invited to change the
platform/OS to all.

Comment 4

[Pierre Saslawsky]

Most of these testcases are wrong because the 'cursor' properties are assigned 
several generic values.  Per the spec, only an 'url()' value can be repeated:
http://www.w3.org/TR/REC-CSS2/ui.html#propdef-cursor.

We still have a bug with multiple URLs, or even with just an URL and a generic 
names.  I'm going to attach a small testcase based on the one provided by the 
reporter.

Comment 5

[Pierre Saslawsky]

Attachment: testcase

Comment 6

[Skewer]

Actually, the spec is vague in this respect. It doesn't specifically say that a
comma-broken list such as "cursor: wait, help;" is invalid, nor does it
specifically suggest it. However, since there are new cursors being added in
CSS3 anyway, I definitely think it SHOULD behave in this way, and at least TRY
to display the page as the author intended.

Comment 7

[Skewer]

P: Your testcase will never work. It is dependent on the "pencil.cur" file being
located in the same directory.

You might want to remove my copyright notice, too...

Comment 8

[Hixie (not reading bugmail)]

'cursor: wait, help;' is invalid CSS per the CSS2 section 18.1.

Comment 9

[Pierre Saslawsky]

The spec is not vague at all.  If you look at http://www.w3.org/TR/REC-CSS2/
ui.html#propdef-cursor, only the [<uri>,] part is followed by an asterisk * 
meaning that it can be repeated.

Also my testcase is valid even though there is no "pencil.cur" attached because 
then {cursor: url("pencil.cur"), wait;} should set the cursor to the 'wait' 
state, which it doesn't.  We have no plans to support url() cursors in the near 
future but we should at least support the syntax that allows for a fall-back 
generic cursor.

Comment 10

[Skewer]

Why would you not have plans to meet the CSS2 standard? I thought you wanted to
win the browser war. Internet Explorer 6.0b supports the cursor property as
specifed by W3C.

Also, why do you keep giving me the W3C URL? I know about that page, or I
wouldn't have posted the URL to it in the initial bug description...

Comment 11

[Hixie (not reading bugmail)]

SkewerMZ: We do plan to do it, just not any time soon -- CSS1 is a higher
priority than CSS2, for obvious reasons.

Comment 12

[Skewer]

Bug 38447 is about CSS2 cursors *not a dup*.
Updating summary.

Comment 13

[Kevin McCluskey (gone)]

Moving to mozilla1.1. Engineers are overloaded!

Comment 14

[Kevin McCluskey (gone)]

Bulk moving from Moz1.1 to future-P1. I will pull from this list when scheduling
work post Mozilla1.0.

Comment 15

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: possible patch

I didn't try compiling this yet.  It removes the cursor image from the style
struct since I doubt we'll implement that anytime in the near future.  It fixes
the parsing to require a generic at the end, which is what the spec does, and
the rule node change relies on that parser change.

Comment 16

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Taking.

Comment 17

[Madhur Bhatia]

cc'ing myself

Comment 18

[Greg K.]

Setting All/All per comment #3.

Comment 19

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

That patch probably isn't the right approach, since we'd want to leave the URLs
in the style data for various reasons (editor round-tripping, DOM access, etc.).

Comment 20

[Vladimir Ermakov]

Attachment: testcase

Testcase trying to set the cursor of a paragraph just like in the CSS2 spec
http://www.w3.org/TR/REC-CSS2/ui.html#propdef-cursor 
When trying to access this value from dom an empty string is returned...

Comment 21

[Skewer]

That file's invalid - use single quotes for the URI string values, else your
style is being processed as "cursor : url(".

Comment 22

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 100499 [details]
testcase

It's also unrelated to this bug, in addition to being invalid.

Comment 23

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: patch

Comment 24

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: patch

Comment 25

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: patch

Comment 26

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: patch

Comment 27

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: patch

Comment 28

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: patch

Comment 29

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: more thorough testcase

Comment 30

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: more thorough testcase

Comment 31

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: more thorough testcase

Comment 32

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 139162 [details] [diff] [review]
patch

r+sr=bzbarsky

Comment 33

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Fix checked in to trunk, 2004-01-17 17:12 -0800.