78320 - javascript strict warnings and error in urlbarBindings.xml

Status: RESOLVED FIXED

(SeaMonkey :: Location Bar, defect, P4)

Description

[Henrik Gemal]

after new modern landing:

JavaScript strict warning:
chrome://navigator/content/urlbarBindings.xml#autocomplete-result-popup.readRDFS
tring() line 4: function readRDFString does not always return a value

JavaScript strict warning:
chrome://navigator/content/urlbarBindings.xml#autocomplete-result-popup.selectBy
() line 9: redeclaration of var sel

Comment 1

[Paul Chen]

marking p4, minor, and mozilla0.9.7

Comment 2

[Paul Chen]

Merging 79969 with this one, updating summary. 79969 is about a js error in
urlbarBindings.xml:

JavaScript error:
chrome://navigator/content/urlbarBindings.xml#autocomplete-result-popup.selectBy()
line 9: this.SelectedIndex has no properties

also reassigning to hewitt

Comment 3

[Paul Chen]

Ooops, sorry for the spam, cleaning up summary. Sure, english is my first
language. ;-)

Comment 4

[Paul Chen]

*** Bug 79969 has been marked as a duplicate of this bug. ***

Comment 5

[Alex Vincent [:WeirdAl]]

New one:
Warning: assignment to undeclared variable searchBarUrl
Source File:
chrome://navigator/content/urlbarBindings.xml#autocomplete-result-popup.updateEngines()
Line: 25

Comment 6

[Alex Vincent [:WeirdAl]]

Attachment: patch for searchBarUrl strict warning

Looking at the source code for urlbarBindings.xml, I note two things:

(1) readRDFString() now unconditionally returns something.  So that strict
warning is gone.

(2) There is only one instance of "var sel" in the selectBy() function.  So
that strict warning is gone as well.

My patch above fixes the only current strict warning in this bug.  I'll have to
check on the error.

Comment 7

[Alex Vincent [:WeirdAl]]

Adding patch keyword as I cannot check this patch in after it gets r= and sr=.

Comment 8

[Alex Vincent [:WeirdAl]]

I've looked through the source of urlbarBindings.xml again; there is currently
no instance of this.SelectedIndex.  There are four instances of
this.selectedIndex, and none of them does the code use to get properties
thereof.  So I'd dare to say the error is gone as well.

Comment 9

[Henrik Gemal]

Haven't seen this for a while. Will reopen if I see it again...
20020117

Comment 10

[Kathleen :Brade]

reopen bug for searchBarUrl warning

Comment 11

[Kathleen :Brade]

Comment on attachment 63970 [details] [diff] [review]
patch for searchBarUrl strict warning

r=brade
hewitt--please sr= and checkin

Comment 12

[a_geek]

sorry, misleading title on bug #165876 which appears more appropriate

Comment 13

[Asa Dotzler [:asa]]

Comment on attachment 63970 [details] [diff] [review]
patch for searchBarUrl strict warning

a=asa (on behalf of drivers) for checkin to the 1.4 branch.

Comment 14

[Steve Chapel]

Checked in by timeless on the trunk.