78360 - JavaScript Error: gContextMenu has no properties

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Message Display, defect)

Description

[Alexey Chernyak]

OS: Win2K
Build: 2001043020

JavaScript Console message:
Error: gMessagePaneContextMenu has no properties

I found gMessagePaneContextMenu being used inside mailWindowOverlay.xul

Steps to reproduce:
1. select a message.
2. right click inside messagepane to bring up context menu.
3. hover mouse either over "Move To" or "Copy To" menu item so that submenu expands.
4. Click inside messagepane.

Reproducible: Always

Comment 1

[Alexey Chernyak]

Alternative steps to reproduce:
1. select a message.
2. right click inside messagepane to bring up context menu.
3. hover mouse either over "Move To" or "Copy To" menu item so that submenu expands.
4. Hover mouse over an item inside the submenu so it expands too.
5. Hover mouse over some other item in root menu so that both submenus disappear.

Comment 2

[James Green]

This is XP code. Seth, if this is an easy fix and you know where to look, can
you describe it here, and I might take a look myself.

Comment 3

[Alexey Chernyak]

gMessagePaneContextMenu variable has been renamed to gContextMenu.

So now I'm seeing the following error every time in context menu a parent of a
submenu gets closed:

Error: gContextMenu has no properties

gContextMenu is now being used inside the following files:

/mailnews/base/resources/content/mailWindowOverlay.xul
/mailnews/base/resources/content/mailContextMenus.js
/mailnews/base/resources/content/mailNavigatorOverlay.xul

However, as per my original bug report the code that generates the error is
probably still somewhere in mailWindowOverlay.xul

CCing ben and racham since they might be familiar with the use of this variable.

Comment 4

[[e-mail]]

Attachment: Proposed patch

Comment 5

[[e-mail]]

The error is caused by the popuphidden handler for the messagepaneContext popup.
However, the cause of the error is revealed by the previous strict JS warning
(always assuming that you have remembered to turn them on :-)
gContextMenu never gets declared in the standalone message window.
The 3pane windows declare gContextMenu indirectly because the sidebar overlays
chrome://communicator/content/contentAreaContextOverlay.xul

Comment 6

[[e-mail]]

Fix checked in.

Comment 7

[Karsten Düsterloh]

This is back, at least in 2003-12-18 and 2003-12-28 on Win2k.
The steps to reproduce this are still valid.

Comment 8

[[e-mail]]

Attachment: Port fix for bug 195878 to mailnews

Comment 9

[[e-mail]]

Fix checked in.

Comment 10

[Henrik Skupin [:whimboo][⌚️UTC+2]]

verified.