Closed
Bug 785673
Opened 12 years ago
Closed 12 years ago
nsprotocolproxyservice::asyncresolve double applies filters
Categories
(Core :: Networking, defect)
Tracking
()
RESOLVED
FIXED
mozilla18
People
(Reporter: mcmanus, Assigned: mcmanus)
References
Details
Attachments
(1 file)
|
4.49 KB,
patch
|
Biesinger
:
review+
|
Details | Diff | Splinter Review |
DoCallback() means to apply the filters after processing the PAC string, but it applies them in all cases. Unfortunately the in the case of no PAC being used that means the filters are applied twice, and as the original list is actually an input into each ->filter() call this can change the result. the existing xpcshell test_protocolproxyservice.js actually triggers this if you change filter test 2 to be asynchronous from its current sync implementation. I've added the async version as test 3 to the test.
|
Assignee | |
Comment 1•12 years ago
|
||
|
||
Updated•12 years ago
|
Attachment #655396 -
Flags: review?(cbiesinger) → review+
|
|
Assignee | |
Comment 2•12 years ago
|
||
https://tbpl.mozilla.org/?tree=Try&rev=f925e785cf68
|
|
Assignee | |
Comment 3•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/03dce8e94aa9 (the pushlog comment says 758673 - 2 digits transposed)
|
|
Assignee | |
Comment 4•12 years ago
|
||
mozilla central 03dce8e94aa9
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla18
You need to log in
before you can comment on or make changes to this bug.
Description
•