78646 - [console] htmlparser must not print to console in opt builds

Status: RESOLVED FIXED

(Core :: DOM: HTML Parser, defect, P3)

Description

[cls]

<formletter>It has been decreed (or requested at any rate) that our release
(read non-debug) builds must not print anything to the console when the app is
running.  See bug 76720 for details.  I have done a preliminary tree scouring
and created mini-patches for each module that has bare printfs.   These patches
are not all inclusive as I didn't even think about xul/js output until post
scour so module owners & peers will still need to scour their modules themselves
as well as make sure the preliminary patches do not break anything.</formletter>

Comment 1

[cls]

Attachment: prelim patch

Comment 2

[cls]

Sorry about the additional spammage but I should clear up a couple of things
before everyone starts replying.

1) I'm just the messenger.  Discussions outside of the specific module/patches
should be discussed in the parent bug ( bug 76720).
2) I have no intention of checking in the patches as is; that's why the bugs are
assigned to someone else ;).
3) The patches are the result of a far & wide-reaching grep across the entire
tree.  They may affect some cases that are not even used and they are far from
optimal.
4) Some platforms/ports will not need the printfs shutoff as they use other
mechanisms to stop the printfs.  That's fine.  Note it in the bug and close it
as invalid(?).  Depending upon the platform/port some people may still be
interested in removing the overhead from the printfs.

Comment 3

[Jon Granrose]

76720 is targetted for 0.9.1. can this be moved up?

Comment 4

[harishd]

ya sure. Shouldn't be too much work.

Comment 5

[chris hofmann]

lets keep dribbling these [console] bugs into the tree as quick as we
can, but they shouldn't hold up or block 0.9.1 so moving the target milestone
to 0.9.2.

Comment 6

[harishd]

moving to 0.9.3

Comment 7

[harishd]

Moving to more realistic target - m0.9.4!

Comment 8

[harishd]

--> 0.9.5

Comment 9

[harishd]

--> 0.9.6

Comment 10

[harishd]

Moving lower priority bugs to m1.0.

Comment 11

[Asa Dotzler [:asa]]

Bugs targeted at mozilla1.0 without the mozilla1.0 keyword moved to mozilla1.0.1 
(you can query for this string to delete spam or retrieve the list of bugs I've 
moved)

Comment 12

[harishd]

This bug has been marked "future" because the original netscape engineer working 
on this is over-burdened. If you feel this is an error, that you or another
known resource will be working on this bug, or if it blocks your work in some way
 -- please attach your concern to the bug for reconsideration. 

Comment 13

[Boris Zbarsky [:bzbarsky]]

Choess, care to take a shot at this?  Most of those method declarations and
implementations should just be inside #ifdef DEBUG....

Comment 14

[Peter Van der Beken [:peterv]]

These are all gone.