Closed
Bug 79249
Opened 23 years ago
Closed 23 years ago
UI problems with the per-server LDAP override UI
Categories
(SeaMonkey :: MailNews: Account Configuration, defect, P1)
Tracking
(Not tracked)
VERIFIED
FIXED
mozilla0.9.2
People
(Reporter: sspitzer, Assigned: srilatha)
References
Details
(Whiteboard: Have a fix.Reviewed. Requesting super review.)
Attachments
(10 files)
87.63 KB,
image/jpeg
|
Details | |
58.19 KB,
image/gif
|
Details | |
56.55 KB,
image/gif
|
Details | |
20.08 KB,
patch
|
Details | Diff | Splinter Review | |
20.00 KB,
patch
|
Details | Diff | Splinter Review | |
20.15 KB,
patch
|
Details | Diff | Splinter Review | |
19.99 KB,
patch
|
Details | Diff | Splinter Review | |
41.22 KB,
image/jpeg
|
Details | |
14.21 KB,
patch
|
Details | Diff | Splinter Review | |
20.15 KB,
patch
|
Details | Diff | Splinter Review |
UI problems with the per-server LDAP override UI 1) it's tacked on at the end of the "server" options for an account. this make the "server" options page too long so the LDAP override UI gets cut off. perhaps it needs to be hidden in some advanced dialog? (cc jglick, for a link to the spec) 2) when resizing, the LDAP override UI doesn't behave right. it should be "attached" to the element above it, not the bottom of the window. here comes a screen shot.
Reporter | ||
Comment 1•23 years ago
|
||
Updated•23 years ago
|
Keywords: mozilla0.9.1,
ui
OS: Windows NT → All
Comment 2•23 years ago
|
||
This does not look good. I talked with dmose and mpt about this for a few days ago, cc'ing.
Comment 4•23 years ago
|
||
Priority P2, TFV 0.9.1.
Priority: -- → P2
Target Milestone: --- → mozilla0.9.1
Reporter | ||
Comment 5•23 years ago
|
||
the per server LDAP override UI seems advanced to me. since space is at a minimun, any objections to adding a "Advanced..." button and moving this (and other advanced server settings) to it? jglick / mpt?
Comment 6•23 years ago
|
||
I suggest the following changes to this panel, some of which are just to make it more understandable, but some of which will also help it fit in 640*480: 1. Put the `Port:' field to the right of the `Server Name:' field. These two are highly related, and it makes no sense for them to be separated by the `User Name:' field. 2. Rename the `Server Type:' field to `Type:' (to remove redundancy), and place it below the server name, not above it. 3. Remove the `Server Settings' group box, which is redundant with the name of the panel itself. 4. Rename `Limit message download to [ ] kB per message' (which sounds like it might truncate the message!) to `Only download messages which are [ ] K or smaller'. 5. Change `Empty Trash on Exit' to `Empty the Trash folder when I exit Mozilla', and remove the stray padding above it. 6. Change the `Local directory:' field to `Local copies are stored in:', and put the field to the right of the label instead of below it. 7. Remove the <spring> (I assume that's the culprit) which is pushing the LDAP settings down to the bottom of the panel. 8. Remove the `LDAP Directory Server' group box, which is redundant with the label for the checkbox. 9. Change the checkbox to two radio buttons, `Use my global LDAP server preferences for this account', and `Use a different LDAP server:'. 10. Put the LDAP server popup menu next to the second radio button, with no extra label. Now, if those changes don't make enough room (and I think they should be made even if they don't make enough room), then you will indeed need a sub-dialog. I would suggest labelling the button for such a dialog as `LDAP Options ...', rather than the mysterious-sounding `Advanced ...'.
4. `Do not download messages larger than [ ] K' What does this have to do w/ the bug summary 'LDAP'?
I like some of mpt's cleanup ideas. Above is a minimal changes idea.
Reporter | ||
Comment 10•23 years ago
|
||
now that we have twisties, why not show "LDAP" as a settings child of the server?
Comment 11•23 years ago
|
||
We could do that too, but we'd have to distinguish between "Mail Server" and "LDAP Server" in the list.
Reporter | ||
Comment 12•23 years ago
|
||
or call it "Addressing Settings" or whatever. those aren't the LDAP server settings, it which LDAP server to use for autocomplete when using that accounts identity, right?
Comment 13•23 years ago
|
||
I especially like the last couple of suggestions by sspitzer and jglick. This would help us avoid the "maze of little dialogs" which is currently required.
Comment 14•23 years ago
|
||
Assignee | ||
Comment 15•23 years ago
|
||
I like the idea of having a separate panel for LDAP, but the panel looks pretty empty. Few suggestions: 1) we can name the panel "Addressing" instead of "LDAP Directory" 2) Enclose all the contents in a box. 3) Move the dropdown listbox and Edit Directories button to the next line. May be we can add some addressing prefs in here!!
Comment 16•23 years ago
|
||
Robin, can you suggest a name for the panel? A group box really isn't necessary since everything on the panel would be in that group box.
Comment 17•23 years ago
|
||
Setting target milestone to 0.9.2 (check it in anytime, even before, when the tree is open for). Per PDT triage.
Target Milestone: mozilla0.9.1 → mozilla0.9.2
Assignee | ||
Comment 18•23 years ago
|
||
I think enclosing it in a box will make it look better. Jennifer do we have a name yet?
Comment 19•23 years ago
|
||
"Addressing" to match the global pref is probably fine.
Comment 20•23 years ago
|
||
Agree.
Comment 21•23 years ago
|
||
*** Bug 78979 has been marked as a duplicate of this bug. ***
Updated•23 years ago
|
Priority: P2 → P1
Assignee | ||
Comment 22•23 years ago
|
||
The override global preference saved fine using the checkbox. But now based on the new spec, using the radiogroup the preference is not getting saved right This is the code I have <radiogroup orient="vertical" wsm_persist="true" id="identity.overrideGlobalPref" pref="true" preftype="bool" prefattribute="value"> <radio group="identity.overrideGlobalPref" id="useGlobalPref1" value="false" label="&useGlobal.label;"/> <radio group="identity.overrideGlobalPref" id="useGlobalPref2" value="true" label="&directories.label;"/> </radiogroup> clicking on the first radio button does not save a value of false. Any suggestions?
Assignee | ||
Comment 23•23 years ago
|
||
Jennifer, since I cannot get the radio group to work, can we use checkbox (like before) instead of radiogroup.
Assignee | ||
Comment 24•23 years ago
|
||
Copying Bhuvan for sugeestions.
Comment 25•23 years ago
|
||
If possible, and especially since we have the space now, I think the radio buttons make the choices much more understandable for users.
Assignee | ||
Comment 26•23 years ago
|
||
Assignee | ||
Comment 27•23 years ago
|
||
Assignee | ||
Comment 28•23 years ago
|
||
Assignee | ||
Comment 29•23 years ago
|
||
The latest patch has attributes fro pref locking and I made a minor modification like indentation for radiogroup. ccing Mohanb for review. Bhuvan can you take a look at the patch too. Seth can you sr Thanks to serge, edyyk and mohan in helping solve the radiogroup problem.
Status: NEW → ASSIGNED
Comment 30•23 years ago
|
||
Can you post this patch at "mailnews" level instead of at "mozilla" level?
Assignee | ||
Comment 31•23 years ago
|
||
Comment 32•23 years ago
|
||
r=mohanb;
Assignee | ||
Updated•23 years ago
|
Whiteboard: Have a fix.Reviewed. Requesting super review.
Reporter | ||
Comment 33•23 years ago
|
||
can you attach a screen shot so I can see how it looks with your patch?
Assignee | ||
Comment 34•23 years ago
|
||
Reporter | ||
Comment 35•23 years ago
|
||
thanks for the screen shot. that looks much better than the old way. sr=sspitzer cc'ing msanz / nhotta. I think you'll need L10n approval before checking in, because of the string changes.
Comment 36•23 years ago
|
||
Sorry I can't give approval for any UI changes at this point. If you change this now it will be in English in all of our localized builds. Please check it in after BETA. thanks
Comment 37•23 years ago
|
||
The beta is on 0.9.1 branch. The trunk is "after beta." So, it's OK to check this in before the RTM UI freeze.
Comment 38•23 years ago
|
||
Mcarlson, note that those rules only apply to the NS tree. One can still fix this on the mozilla tree, as long as we get approval from drivers.
Comment 39•23 years ago
|
||
* This stuff should be in a groupbox, right? * Server is capitalized in the second label but not the first. * In other bugs, we seem to have decided second-person ('you', not 'my') * Not much content for a panel, what else is planned to go here? Jennifer, Matthew, German, Ben, others, what do you all think?
Assignee | ||
Comment 40•23 years ago
|
||
* This stuff should be in a groupbox, right? Comments from Jennifer: A group box really isn't necessary since everything on the panel would be in that group box. * Server is capitalized in the second label but not the first. This is my mistake. Server is not capitalized in the spec . Will attach a new patch with the changes.
Comment 41•23 years ago
|
||
Groupbox - it doesn't really need the groupbox since its the only 'group' on the panel, but I don't have a problem with having a groupbox around the items if folks prefer. Capitalization - fixed by Srilatha. You vs My - I don't think this is a problem, but then I'm not a tech writer! :-) cc'ing Robin's co-worker while she's out. jatin@netscape.com Not much content - Yeah, I know, but it wouldn't fit on existing panels as you can see from the examples early in the bug. As for future stuffs, the LDAP folks might know that one.
Comment 42•23 years ago
|
||
Although there isn't a consistent standard in the preferences, using the first-person "my" in this pref panel seems appropriate. "Me" and "my" are used in other places in preferencs as well.
Assignee | ||
Comment 43•23 years ago
|
||
Assignee | ||
Comment 44•23 years ago
|
||
The stuff that might be added to this panel in the future: We want to add the ability to select more than one server for autocompletion. So the dropdown list box might be changed to a list. May be some more addressing preferences.
Keywords: mozilla0.9.1
Assignee | ||
Comment 45•23 years ago
|
||
Comment 46•23 years ago
|
||
r=mohanb;
Comment 47•23 years ago
|
||
Adding DE Team to cc-list
Comment 48•23 years ago
|
||
a= asa@mozilla.org for checkin to the trunk. (on behalf of drivers)
Assignee | ||
Comment 49•23 years ago
|
||
Fix checked in.
Assignee | ||
Comment 50•23 years ago
|
||
marking this as fixed
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
Comment 51•23 years ago
|
||
2001061304 Wins trunk build Verified the fix for the per-server LDAP override UI
Status: RESOLVED → VERIFIED
Updated•20 years ago
|
Product: Browser → Seamonkey
You need to log in
before you can comment on or make changes to this bug.
Description
•