79355 - [CT] classic: toolbar grippies are not as slim as in 4.x

Status: VERIFIED FIXED

(SeaMonkey :: Themes, defect)

Description

[Andreas Franke (gone)]

Submitting this bug with mozilla 0.9 (2001050521) on Linux.
The toolbar grippies in the classic skin are not as slim as in Navigator 4.x .
I find the old style look a lot better.

Comment 1

[John Dobbins]

mozilla/ themes/ classic/ global/ win/ toolbar.css 

change line 44 from
width                 : 12px;

to
width                 : 10px;

Comment 2

[Blake Ross]

--> me

Comment 3

[Blake Ross]

usability/polish, 0.9.4.

Comment 4

[Blake Ross]

--> shilang

Comment 5

[Joe Hewitt (gone)]

-> shliang

Comment 6

[shliang]

Attachment: 10px wide grippies

Comment 7

[Joe Hewitt (gone)]

Comment on attachment 58068 [details] [diff] [review]
10px wide grippies

sr=hewitt

Comment 8

[andreww]

Comment on attachment 58068 [details] [diff] [review]
10px wide grippies

r=andreww

Comment 9

[shliang]

checked in

Comment 10

[Asa Dotzler [:asa]]

Should I file a new bug or re-open this one. The grippies look horrible. I'd be
more than willing to scam the 4.x grippy images or tweak the fatter but much
more attractive Mozilla grippies. 

Comment 11

[Asa Dotzler [:asa]]

It looks to me like this image was too narrow and it's being stretched wider.
The little grip bumps have a highlight and shadow pixel that is are too far
apart. In 4.x we had two vertical columnss of these bumps. Up until recently we
had two columns of bumps in Mozilla. Now we have one column of bumps that are
stretched in width so they no longer look like bumps. 

Comment 12

[Asa Dotzler [:asa]]

I was wrong. What has happened here is that the we only have the highlight pixel
from the right column of bumps and the shadow pixel from the left column of
bumps. I'll attach pictures.

Comment 13

[Asa Dotzler [:asa]]

Attachment: magnification illustrating trimming of essential pixels in toolbar grippies

Here's a magnified image. You can see the 4.x grippy for reference at the left,
the Mozilla grippy as it was a few days ago in the middle and as it is today on
the right.  Note that we're still 1 pixel wider than 4.x and we've destroyed
the two columns of bumps by cutting them each in half. (we'd need to shift
everything left one more pixel and trim a column of pixels from the right side
to get the 4.x image positioning. Then we'd need to restore the shadow and
highlight pixels for the two columns of bumps. Or something like that.

Comment 14

[Asa Dotzler [:asa]]

reopening. this fix should be backed out and done correctly. 

Comment 15

[Asa Dotzler [:asa]]

So the image hasn't changed, just the css.
 
I don't know how any of this works so this is all total speculation (but with
some possibly useful data and suggestions) 
Looking at the grippy in the dom inspector it looks like it's a spacer with the
5 pixel wide texture image for a background.  The spacer has width of 3, and a
right and left margin of 3 and 2 respectively. Maybe if that was changed to a
width of 5 (afterall, the image it contains has a width of 5) and a right margin
of 2 and a left margin of 1 (and maybe we could drop the top margin a couple of
pixels if that's how you move the bumps closer to the twisty) then it would fit
properly in the 10 pixel wide grippy box. 

Here's my probably flawed guess at what's going on.  I'm totally clueless about
XUL and CSS so I'm very likely wrong. 
It looks like we have a grippy box that is 10 pixels wide with an inner border
that takes up two of those width pixels. That leaves 8. Inside that we have a
spacer that is 3 pixels wide with margins that add 5 pixels to its width. That
fills the grippy box's 8 pixels. Inside that spacer we have a 5 pixel wide image
that is being cut down to three because the spacer is only 3 pixels wide. 

Comment 16

[Asa Dotzler [:asa]]

Attachment: maybe a patch that makes the grippy better

based on my probably wrong guess at what is going on I edited toolbar.css to
change the margins on the spacer and it seems to make the grippy look better.

Comment 17

[Joe Hewitt (gone)]

Comment on attachment 59989 [details] [diff] [review]
maybe a patch that makes the grippy better

sr=hewitt

Comment 18

[Asa Dotzler [:asa]]

Attachment: even better patch. narrow grippy one more pixel than shliang's and shift the texture left one more pixel so it matches 4.x

Comment 19

[Jason Kersey]

r=kerz

Comment 20

[Asa Dotzler [:asa]]

andreww, this is the smaller (windows classic) patch that just makes the image
in the grippy visible. Can you do the mac classic work if there is any and get
this checked in. It's pretty ugly and the fix for this small part of it looks
simple (the collapsed grippy problem is another bug I think). 

Comment 21

[shliang]

Comment on attachment 59992 [details] [diff] [review]
even better patch. narrow grippy one more pixel than shliang's and shift the texture left one more pixel so it matches 4.x 

why did you change the top and bottom margins? also, are the collapsed grippies
going to be changed too?

Comment 22

[Asa Dotzler [:asa]]

The collapsed grippies have another problem. I found a workaround that at least
displays the grippy image when collapsed but it isn't the right fix (i think)
because the grippies don't ahve the correct size when collapsed. (I just
hardcoded in a width). I can make a patch for that if it's useful but I think
it's wrong. 

I changed the top and bottom margins because it looked more like 4.x that way.
Feel free to throw out my patch (I don't really know what I'm doing) and do it
the right way. It's just that it looks really bad now and I thought that since I
had something that made it look better that I'd try to get that in. 

Comment 23

[shliang]

oh your patch is fine, i was just wondering. maybe the collapsed grippies should
be changed too even if they are broken now, just so they will match when they do
get fixed. i can do it if you want, since it was my fault that they got messed
up in the first place (i just did exactly what comment #1 said without checking
first to make sure it was correct).

Comment 24

[Asa Dotzler [:asa]]

Attachment: combined the above fix for grippies with a hack for collapsed grippies

OK. like I said, this is probably not the correct fix but it does at least
return the bumps to the toolbar grippies in the collapsed and expanded states.

Comment 25

[Joe Hewitt (gone)]

Comment on attachment 60841 [details] [diff] [review]
combined the above fix for grippies with a hack for collapsed grippies 

r=shliang
sr=hewitt

Comment 26

[shliang]

checked in asa's patch and same changes for mac

Comment 27

[Asa Dotzler [:asa]]

Thanks shliang! Verified on win32 121203 build but mac is totally hosed so I
can't test that yet.

Comment 28

[Patty Mac]

verified on linux and mac 0s 9.2 (2001-12-21-04-trunk)