79767 - IMAP SEARCH commands include HEADER unnecessarily

Status: RESOLVED FIXED

(MailNews Core :: Networking: IMAP, defect, P3)

Description

[Robert O'Callahan (:roc) (email my personal email if necessary)]

The HEADER search term should only be used to search headers that are not
already defined as searchable terms in IMAP. In other words, when searching for
SUBJECT, TO, CC, SENDER, etc, HEADER should not be included.

When HEADER is included, Cyrus imapd (at least) does a very expensive search
through the texts of the messages; without HEADER it searches through its cache
and performs the search much much more quickly.

Comment 1

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: Proposed patch

Comment 2

[Robert O'Callahan (:roc) (email my personal email if necessary)]

I wouldn't feel 100% comfortable committing that patch until we have a clue why
those HEADERs were being sent in the first place (or we verify that there are no
broken servers around that require it for some reason).

Comment 3

[Henrik Gemal]

should we try to get review or is this an enhancement...?

Comment 4

[Robert O'Callahan (:roc) (email my personal email if necessary)]

It's a performance issue mainly.

Comment 5

[David :Bienvenu]

Comment on attachment 33713 [details] [diff] [review]
Proposed patch

this patch looks good to me, from reading the rfc - sorry I forgot to review
it.

Comment 6

[Robert O'Callahan (:roc) (email my personal email if necessary)]

I'll take this over so I can track it :-).

Who's a good super reviewer for this area?

Comment 7

[David :Bienvenu]

mscott or sspitzer, it doesn't really matter.

Comment 8

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: fresh patch

The old patch was somewhat rotten. This patch is up to date and the code is a
bit simpler. It only prepends HEADER for the arbitaryHeader terms.

Comment 9

[Wayne Mery (:wsmwk)]

hmm, updated patch was never set for review.

Comment 10

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Wayne, does this bug still matter to you, and can you confirm that the patch
still fixes the issue? If so then we can send this forward for approval.

Comment 11

[Robert O'Callahan (:roc) (email my personal email if necessary)]

checked into trunk

Comment 12

[David :Bienvenu]

this needs to be landed on the 1.8.1 branch to fix bug 344290