799441 - install gio extension

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Jan Beich]

My firefox install:

$ ls $prefix/lib/firefox/components
binary.manifest
libbrowsercomps.so
libmozgnome.so

$ cat $prefix/lib/firefox/components/binary.manifest
binary-component libmozgnome.so
binary-component libnkgio.so
binary-component libbrowsercomps.so

Comment 1

[Jan Beich]

Attachment: Bug 799441 - Install GIO extension, everywhere GNOMEVFS2's one is.

Comment 2

[Mike Hommey [:glandium]]

Thinking about it, maybe we just want to remove FORCE_SHARED_LIB from extensions/gio/Makefile.in. What do you think, Karl?

Comment 3

[Karl Tomlinson (:karlt)]

(In reply to Mike Hommey [:glandium] from comment #2)
> Thinking about it, maybe we just want to remove FORCE_SHARED_LIB from
> extensions/gio/Makefile.in. What do you think, Karl?

That sounds a step in the right direction, but would also need changes to toolkit/library/Makefile.in.  See also bug 794698.

Comment 4

[Karl Tomlinson (:karlt)]

Comment on attachment 669466 [details] [diff] [review]
Bug 799441 - Install GIO extension, everywhere GNOMEVFS2's one is.

This is correct; it makes the build system do what was intended.

If someone wants to put together a patch to build this into libxul, then that would be a better fix.  I guess EXTRA_DSO_LDOPTS could then also be removed.

Comment 5

[Magnus Melin [:mkmelin]]

(I don't know what effect it has)
Is this something thunderbird should have as well? http://mxr.mozilla.org/comm-central/source/mail/installer/package-manifest.in#750

Comment 6

[Karl Tomlinson (:karlt)]

(In reply to Magnus Melin from comment #5)

I'm not clear who or how many people use this.  The gio extension is there to provide the same functionality as the old gnomevfs extension, which is to support loading from smb: and sftp:.

If thunderbird isn't missing the gnomevfs extension, it probably won't miss the gio extension.  Bug 682838 may make the gio extension more useful, though.

Comment 7

[Mark Banner (:standard8)]

Yes Thunderbird does (some people use smb), I filed bug 800137.

Comment 8

[Mike Hommey [:glandium]]

Attachment: Build GIO module in libxul

Comment 9

[Mike Hommey [:glandium]]

Attachment: Build GIO module in libxul

It's kind of gross, but we already have other extensions directories in tier_platform_dirs. Previous iteration didn't actually work because extensions are normally built after libxul.

Comment 10

[Karl Tomlinson (:karlt)]

Comment on attachment 670577 [details] [diff] [review]
Build GIO module in libxul

This looks fine to me if you can find the right place to remove extensions/gio so that make is not run twice in that directory.  Best to wait and see whether Ted thinks this is a step in the right direction.

Comment 11

[Mike Hommey [:glandium]]

(In reply to Karl Tomlinson (:karlt) from comment #10)
> Comment on attachment 670577 [details] [diff] [review]
> Build GIO module in libxul
> 
> This looks fine to me if you can find the right place to remove
> extensions/gio so that make is not run twice in that directory.

That's what the configure.in change does.

Comment 12

[(not currently active) Ted Mielczarek]

Comment on attachment 670577 [details] [diff] [review]
Build GIO module in libxul

Review of attachment 670577 [details] [diff] [review]:
-----------------------------------------------------------------

I really want to get this out of extensions/...

Comment 13

[Mike Hommey [:glandium]]

(In reply to Ted Mielczarek [:ted] from comment #12)
> I really want to get this out of extensions/...

Let's do that in a followup

Comment 14

[Mike Hommey [:glandium]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d243048bc966

Comment 15

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/d243048bc966

Comment 17

[Mike Hommey [:glandium]]

Comment on attachment 670577 [details] [diff] [review]
Build GIO module in libxul

[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 713802
User impact if declined: Feature regression on linux builds for smb:// and sftp:// protocols
Testing completed (on m-c, etc.): Landed on m-c
Risk to taking this patch (and alternatives if risky): The code was built but not installed ; with the patch it is linked in libxul. As long as it builds on m-c (which it does), there's no risk.
String or UUID changes made by this patch: None

Comment 18

[Mike Hommey [:glandium]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/636b289899a4