8009 - editor/base/*Txn.cpp hard-coded strings (not in UI)

Status: VERIFIED FIXED

(Core :: DOM: Editor, defect, P3)

Description

[Kathleen :Brade]

in ChangeAttributeTxn.cpp
ChangeAttributeTxn::GetUndoString and ChangeAttributeTxn::GetRedoString have
hard-coded strings in them.  These will need to be pulled out for L10n efforts.

Comment 1

[Kathleen :Brade]

Also...
file                   methods
CreateElementTxn.cpp   GetUndoString, GetRedoString
DeleteTextTxn.cpp      GetUndoString, GetRedoString
DeleteElementTxn.cpp   GetUndoString, GetRedoString
DeleteRangeTxn.cpp     GetUndoString, GetRedoString
InsertTextTxn.cpp      GetUndoString, GetRedoString
JoinElementTxn.cpp     GetUndoString, GetRedoString
SplitElementTxn.cpp    GetUndoString, GetRedoString

Comment 2

[Kathleen :Brade]

reassign to myself; cc [e-mail]

Comment 3

[bobj]

I assume these are error messages that you need to resource?
Check out: http://www.mozilla.org/projects/intl/string-resources.html

Cc'ing Tao and Erik who can help with the strres APIs.

Comment 4

[buster]

Can wait until M10. We have very few places where we have embedded strings, so
I'm not concerned about leaving this until after we've hit full functionality.
These are strings that can be made available to the UI to give more meaning to
the user about what action will be undone|redone.

Comment 5

[bobj]

Of course, sooner is better.  The L10N engineers have already begun creating
pseudo-localizations to test localizability where possible.

Comment 6

[bobj]

Of course, sooner is better.  The L10N engineers have already begun creating
pseudo-localizations to test localizability where possible.

Comment 7

[bobj]

Of course, sooner is better.  The L10N engineers have already begun creating
pseudo-localizations to test localizability where possible.

Comment 8

[Kathleen :Brade]

changing contact person to [e-mail]

Comment 9

[Kathleen :Brade]

moving to M9

Comment 10

[Kathleen :Brade]

M10

Comment 11

[Kathleen :Brade]

m11

Comment 12

[Kathleen :Brade]

infrastructure in place; move to M12 (note: only logging currently uses the hard-
coded strings)

Comment 13

[rubydoo123]

setting to M14, this can wait till after dogfood

Comment 14

[msanz]

Beth, this needs to be fixed before M14 because we are localizing M14. Can you
set the milestone to M13? I agree it's not dogfood, but early M13 is our
deadline for translation. Thanks!

Comment 15

[rubydoo123]

removing whiteboard summary text

Comment 16

[bobj]

Nominating for Beta1 since we are localizing Beta1.

Comment 17

[Kathleen :Brade]

I would like this bug reconsidered and marked PDT-
Removing PDT+ on status whiteboard so it will be reconsidered.

These strings are only used in the logging system which is a "debug" thing; they 
don't appear anywhere in the UI.

This bug could be fixed in 3 ways:
 * remove the strings altogether and break logging
 * create a properties file and write extra code to handle these strings 
(temporarily)
 * the "right" way which is dependent on command-dispatching which may not be 
completely in place for beta1 (bug #18395 I think)

Comment 18

[leger]

Putting on the PDT- radar for beta1. 

Comment 19

[Kathleen :Brade]

moving to M15 (hopefully Simon's / Hyatt's stuff will be done by then)

Comment 20

[Kathleen :Brade]

remove beta1 keyword and PDT- status whiteboard

Comment 21

[Kathleen :Brade]

move to Future for now

Comment 22

[rubydoo123]

adding help wanted keyword

Comment 23

[kinmoz]

Taking this off of brade's plate.

Comment 24

[kinmoz]

The GetUndoString() and GetRedoString() methods were ripped out when I landed 
changes for bug #66308, so this bug is effectively fixed. ;-)

The only strings left in the transactions are left for logging/debugging which 
will never appear in the UI, so they don't need translating.

Comment 25

[sujay]

Kin/Kathy, can you verify this one and mark VERIFIED-FIXED ? thx.

Comment 26

[kinmoz]

Marking verified.