80807 - Composer should have only 1 menu item for Find & Replace

Status: VERIFIED FIXED

(Core :: DOM: Editor, defect, P3)

Description

[Kathleen :Brade]

Composer should have only one menu item for Find and Replace...
Right now there are two menu items under the Edit menu that do exactly the same
thing.  This is very confusing.

Comment 1

[Charles Manske]

Yuck! I agree. Seems like we should do this for 6.5 (there's one more chance
to make UI string changes, according to Robin.) Setting to 0.9.2
The current "Find" should be something like "Find / Replace..." or
"Find & Replace..."
Any preferences?

Comment 2

[Simon Fraser [no longer active]]

'Find and Replace'

Comment 3

[robinf]

Either "Find and Replace..." or "Find & Replace..." 

Comment 4

[Charles Manske]

So we need to wait for the "checkin window" before final UI freeze to check this
in, correct (i.e., can't do it now)?

Comment 5

[Ryan Cassin]

Attachment: Patch for bug

Comment 6

[Charles Manske]

Thanks, Ryan
r=cmanske

Comment 7

[Kathleen :Brade]

these fixes should certainly go in, but don't we need to fix mail compose too?

I think we need to change these files:
 ComposerCommands.js   --> remove nsReplaceCommand & registration of cmd_replace
 MsgComposeCommands.js --> remove 3 lines which reference cmd_replace
 messengercomposer.xul --> remove menu item

Comment 8

[Ryan Cassin]

Attachment: Patch for suggested mailnews changes

Comment 9

[Ryan Cassin]

Attachment: Original patch + ComposerCommands Change

Comment 10

[Simon Fraser [no longer active]]

sr=sfraser. cc kerz to check that other users of editor in the commercial tree 
are OK.

Comment 11

[anthonyd]

looks great
r=anthonyd

Comment 12

[Asa Dotzler [:asa]]

a= [e-mail] for checkin to 0.9.1

Comment 13

[Håkan Waara]

Ryan wanted me to check this in for him, but apparently the mailnews part of the
patch is un-sr='ed.

cc sspitzer for review.    I won't check this in (yet?).

Comment 14

[(not reading, please use [e-mail] instead)]

assuming it's ok with jglick, sr=sspitzer

jglick, if it is ok can you update the spec?

http://www.mozilla.org/mailnews/specs/compose/Comp_Menus.html

Comment 15

[Asa Dotzler [:asa]]

a= [e-mail] for checkin to the trunk.
(on behalf of drivers)

Comment 16

[Charles Manske]

checked in.

Comment 17

[jglick]

Updated spec on its way...

Comment 18

[sujay]

verified.