81743 - mozctlx.dll causes error during smartupdate from 6.0x to daily builds

Status: VERIFIED FIXED

(SeaMonkey :: Installer, defect)

Description

[Sean Su]

With the new registration of mozctlx.dll by browser.xpi, people smartupdating 
from 6.0/6.01 to daily builds will run into nsXPIDLCString errors when 
mozctlx.dll is being registered.

This is probably because mozctlx.dll expects to find the correct versions of 
mozilla dlls already installed by the time the registration is done.  This is an 
incorrect assumption when installing via SmartUpdate because the correct file 
will not have been installed properly until after a reboot (because they're in 
use at the time of the SmartUpdate).  The users will also see error messages 
thrown by mozctlx.dll similar to bug 81627.  However, once dismissed, the 
installation continues as normal.

Once solution would be to not perform the required registration in the .xpi 
file.  A new .xpi file could be written to just perform this registration 
process via the SmartUpdate pages, but only after detecting that the user had 
already updated to the latest version of the browser.

This means that the user, after already visiting the SmartUpdate pages to update 
to the latest version, they will have to come back again to run this .xpi file 
to perform the registration.

I'm not sure how else to resolve this registration issue.

Comment 1

[Sean Su]

Just thought about another option:

Not have browser.xpi register the dll, but instead have the native installer 
register the dll at the end of its installation.  As for the SmartUpdate, simply 
have browser.xpi create a shortcut in the start menu that will simply register 
the dll.

Comment 2

[Sean Su]

Attachment: patch #1 (ns tree)

Comment 3

[Sean Su]

Attachment: patch #1 (moz tree)

Comment 4

[Sean Su]

Attachment: patch #1 (moz tree - another file)

Comment 5

[Sean Su]

Patches #1 will move the registering of mozctlx.dll from browser.xpi to the 
native installer.  This means that mozctlx.dll will only be registered when the 
browser is installed via the native windows installer.  It will not be 
registered when doing a smartupdate with browser.xpi.

Comment 6

[Sean Su]

got r=sgehani

Comment 7

[Scott MacGregor]

sr=mscott

Comment 8

[Sean Su]

this bug is no longer valid because of bug 82202.  I will leave it as REMIND for 
when mozctlx.dll registration comes back.

Comment 9

[Christopher Hoess (gone)]

REMIND is deprecated per bug 35839. Please find another resolution for this bug.

Comment 10

[Daniel Veditz [:dveditz]]

Alright, fixed then.

Comment 11

[Grace Bush]

v